From 6d36219e55923d3188485e010acc47edc025c84a Mon Sep 17 00:00:00 2001 From: Abhi <43648792+abhipatel12@users.noreply.github.com> Date: Wed, 28 Jan 2026 23:58:20 -0500 Subject: [PATCH] feat(cli): show hooksConfig.enabled in settings dialog (#17810) --- docs/cli/settings.md | 7 ++++--- docs/get-started/configuration.md | 1 + packages/cli/src/config/settingsSchema.ts | 4 ++-- schemas/settings.schema.json | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/cli/settings.md b/docs/cli/settings.md index 6cee55b709..a581875a35 100644 --- a/docs/cli/settings.md +++ b/docs/cli/settings.md @@ -130,8 +130,9 @@ they appear in the UI. ### HooksConfig -| UI Label | Setting | Description | Default | -| ------------------ | --------------------------- | ------------------------------------------------ | ------- | -| Hook Notifications | `hooksConfig.notifications` | Show visual indicators when hooks are executing. | `true` | +| UI Label | Setting | Description | Default | +| ------------------ | --------------------------- | -------------------------------------------------------------------------------- | ------- | +| Enable Hooks | `hooksConfig.enabled` | Canonical toggle for the hooks system. When disabled, no hooks will be executed. | `true` | +| Hook Notifications | `hooksConfig.notifications` | Show visual indicators when hooks are executing. | `true` | diff --git a/docs/get-started/configuration.md b/docs/get-started/configuration.md index 6ffdd87282..c8c5d31b09 100644 --- a/docs/get-started/configuration.md +++ b/docs/get-started/configuration.md @@ -901,6 +901,7 @@ their corresponding top-level category object in your `settings.json` file. - **Description:** Canonical toggle for the hooks system. When disabled, no hooks will be executed. - **Default:** `true` + - **Requires restart:** Yes - **`hooksConfig.disabled`** (array): - **Description:** List of hook names (commands) that should be disabled. diff --git a/packages/cli/src/config/settingsSchema.ts b/packages/cli/src/config/settingsSchema.ts index ffa4c6111a..6aff11ba90 100644 --- a/packages/cli/src/config/settingsSchema.ts +++ b/packages/cli/src/config/settingsSchema.ts @@ -1601,11 +1601,11 @@ const SETTINGS_SCHEMA = { type: 'boolean', label: 'Enable Hooks', category: 'Advanced', - requiresRestart: false, + requiresRestart: true, default: true, description: 'Canonical toggle for the hooks system. When disabled, no hooks will be executed.', - showInDialog: false, + showInDialog: true, }, disabled: { type: 'array', diff --git a/schemas/settings.schema.json b/schemas/settings.schema.json index 0a1ad9e879..b34c2add71 100644 --- a/schemas/settings.schema.json +++ b/schemas/settings.schema.json @@ -1537,7 +1537,7 @@ "enabled": { "title": "Enable Hooks", "description": "Canonical toggle for the hooks system. When disabled, no hooks will be executed.", - "markdownDescription": "Canonical toggle for the hooks system. When disabled, no hooks will be executed.\n\n- Category: `Advanced`\n- Requires restart: `no`\n- Default: `true`", + "markdownDescription": "Canonical toggle for the hooks system. When disabled, no hooks will be executed.\n\n- Category: `Advanced`\n- Requires restart: `yes`\n- Default: `true`", "default": true, "type": "boolean" },