diff --git a/packages/cli/src/ui/constants/tips.ts b/packages/cli/src/ui/constants/tips.ts index 456b26a9e8..1ff19af199 100644 --- a/packages/cli/src/ui/constants/tips.ts +++ b/packages/cli/src/ui/constants/tips.ts @@ -90,7 +90,7 @@ export const INFORMATIVE_TIPS = [ 'Toggle the todo list display with Ctrl+T…', 'See full, untruncated responses with Ctrl+O…', 'Toggle auto-approval (YOLO mode) for all tools with Ctrl+Y…', - 'Cycle through approval modes (Default, Plan, Auto-Edit) with Shift+Tab…', + 'Cycle through approval modes (Default, Auto-Edit, Plan) with Shift+Tab…', 'Toggle Markdown rendering (raw markdown mode) with Alt+M…', 'Toggle shell mode by typing ! in an empty prompt…', 'Insert a newline with a backslash (\\) followed by Enter…', diff --git a/packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts b/packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts index 785e05aa15..17e4a108fb 100644 --- a/packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts +++ b/packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts @@ -237,15 +237,7 @@ describe('useApprovalModeIndicator', () => { }), ); - // DEFAULT -> PLAN - act(() => { - capturedUseKeypressHandler({ name: 'tab', shift: true } as Key); - }); - expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.PLAN, - ); - - // PLAN -> AUTO_EDIT + // DEFAULT -> AUTO_EDIT act(() => { capturedUseKeypressHandler({ name: 'tab', shift: true } as Key); }); @@ -253,7 +245,15 @@ describe('useApprovalModeIndicator', () => { ApprovalMode.AUTO_EDIT, ); - // AUTO_EDIT -> DEFAULT + // AUTO_EDIT -> PLAN + act(() => { + capturedUseKeypressHandler({ name: 'tab', shift: true } as Key); + }); + expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( + ApprovalMode.PLAN, + ); + + // PLAN -> DEFAULT act(() => { capturedUseKeypressHandler({ name: 'tab', shift: true } as Key); }); diff --git a/packages/cli/src/ui/hooks/useApprovalModeIndicator.ts b/packages/cli/src/ui/hooks/useApprovalModeIndicator.ts index 7fd25bd600..dfb1420303 100644 --- a/packages/cli/src/ui/hooks/useApprovalModeIndicator.ts +++ b/packages/cli/src/ui/hooks/useApprovalModeIndicator.ts @@ -59,14 +59,14 @@ export function useApprovalModeIndicator({ const currentMode = config.getApprovalMode(); switch (currentMode) { case ApprovalMode.DEFAULT: - nextApprovalMode = config.isPlanEnabled() - ? ApprovalMode.PLAN - : ApprovalMode.AUTO_EDIT; - break; - case ApprovalMode.PLAN: nextApprovalMode = ApprovalMode.AUTO_EDIT; break; case ApprovalMode.AUTO_EDIT: + nextApprovalMode = config.isPlanEnabled() + ? ApprovalMode.PLAN + : ApprovalMode.DEFAULT; + break; + case ApprovalMode.PLAN: nextApprovalMode = ApprovalMode.DEFAULT; break; case ApprovalMode.YOLO: