From 2026e22c8f170ea7b64c0c4c1f0509dcd2db5616 Mon Sep 17 00:00:00 2001
From: Tienson Qin <tiensonqin@gmail.com>
Date: Tue, 15 Aug 2023 14:15:40 +0800
Subject: [PATCH] enhance: add delete button near to tags

---
 src/main/frontend/common.css            |  1 +
 src/main/frontend/components/block.cljs | 28 +++++++++++++++++++++----
 2 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/src/main/frontend/common.css b/src/main/frontend/common.css
index e507613c80..21244f713b 100644
--- a/src/main/frontend/common.css
+++ b/src/main/frontend/common.css
@@ -682,6 +682,7 @@ a.tag {
   cursor: pointer;
   color: var(--ls-tag-text-color, #045591);
   opacity: var(--ls-tag-text-opacity, 0.8);
+  padding-right: 1.125rem;
 }
 
 a.tag:hover {
diff --git a/src/main/frontend/components/block.cljs b/src/main/frontend/components/block.cljs
index d074fc4638..0765557c55 100644
--- a/src/main/frontend/components/block.cljs
+++ b/src/main/frontend/components/block.cljs
@@ -534,6 +534,7 @@
 
 (rum/defcs page-inner <
   (rum/local false ::mouse-down?)
+  (rum/local false ::hover?)
   "The inner div of page reference component
 
    page-name-in-block is the overridable name of the page (legacy)
@@ -541,18 +542,20 @@
    All page-names are sanitized except page-name-in-block"
   [state config page-name-in-block page-name redirect-page-name page-entity contents-page? children html-export? label whiteboard-page?]
   (let [*mouse-down? (::mouse-down? state)
+        *hover? (::hover? state)
         tag? (:tag? config)
         config (assoc config :whiteboard-page? whiteboard-page?)
         untitled? (model/untitled-page? page-name)]
-    [:a
+    [:a.relative
      {:tabIndex "0"
       :class (cond-> (if tag? "tag" "page-ref")
-               (:property? config)
-               (str " page-property-key block-property")
+               (:property? config) (str " page-property-key block-property")
                untitled? (str " opacity-50"))
       :data-ref page-name
       :draggable true
       :on-drag-start (fn [e] (editor-handler/block->data-transfer! page-name-in-block e))
+      :on-mouse-over #(reset! *hover? true)
+      :on-mouse-leave #(reset! *hover? false)
       :on-mouse-down (fn [_e] (reset! *mouse-down? true))
       :on-mouse-up (fn [e]
                      (when @*mouse-down?
@@ -596,7 +599,24 @@
                        (util/trim-safe page-name))
                _ (when-not page-entity (js/console.warn "page-inner's page-entity is nil, given page-name: " page-name
                                                         " page-name-in-block: " page-name-in-block))]
-           (if tag? (str "#" s) s))))]))
+           (if tag? (str "#" s) s))))
+
+     (let [repo (state/get-current-repo)
+           block-id (:block/uuid config)
+           block (when block-id (db/entity [:block/uuid block-id]))
+           tags-id (:block/uuid (db/entity [:block/name "tags"]))]
+       (when (and block tag? @*hover? (config/db-based-graph? repo))
+         [:a.close.fade-in
+          {:class "absolute top-0 right-0"
+           :title "Remove this tag"
+           :on-mouse-down
+           (fn [e]
+             (util/stop e)
+             (property-handler/delete-property-value! repo block
+                                                      tags-id
+                                                      (:block/uuid page-entity))
+             (prn "remove this tag"))}
+          (ui/icon "x")]))]))
 
 (rum/defc page-preview-trigger
   [{:keys [children sidebar? tippy-position tippy-distance fixed-position? open? manual?] :as config} page-name]