clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-04-24 22:25:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: finish frontend independence from worker and add lint

Browse Source 
Remaining fixes worker all file related. Fixes LOG-3717
This commit is contained in:
Gabriel Horner
2024-08-09 12:16:20 -04:00
parent 20eac03cea
commit 261118d4dc
15 changed files with 87 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/dev-practices.md
View File

@@ -122,11 +122,12 @@ The main convention is that file and db specific files go under directories name
### Separate Worker from Frontend
The worker and frontend code share common code from deps/ and `frontend.common.*`. However, the worker should never depend on other frontend namespaces as it could pull in libraries like React which cause it to fail hard. Run this linter to ensure worker namespaces are not dependent on other frontend namespaces:
The worker and frontend code share common code from deps/ and `frontend.common.*`. However, the worker should never depend on other frontend namespaces as it could pull in libraries like React which cause it to fail hard. Likewise the frontend should never depend on worker namespaces. Run this linter to ensure worker and frontend namespaces don't require each other:
```
$ bb lint:worker-and-frontend-separate
Success!
Valid worker namespaces!
Valid frontend namespaces!
```
## Testing