clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-03 02:16:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: graph-parser test and lint

Browse Source 
Removed test as no error handling is needed for ident generation. Also
removed all related downstream uses of catch for
db-ident/create-db-ident-from-name that are no longer needed
This commit is contained in:
Gabriel Horner
2024-08-19 15:37:43 -04:00
parent eff0d5e7d4
commit 3a4cc55cda
6 changed files with 12 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
deps/graph-parser/test/logseq/graph_parser/exporter_test.cljs vendored
View File

@@ -195,7 +195,7 @@
set))))
(testing "user properties"
(is (= 17
(is (= 18
(->> @conn
(d/q '[:find [(pull ?b [:db/ident]) ...]
:where [?b :block/type "property"]])
@@ -430,22 +430,6 @@
(readable-properties @conn (find-page-by-name @conn "Interstellar")))
"tagged page has configured tag imported as a class"))))
(deftest-async export-files-with-invalid-class-and-property-display-notifications
(p/let [file-graph-dir "test/resources/exporter-test-graph"
files (mapv #(node-path/join file-graph-dir %) ["journals/2024_07_24.md" "ignored/invalid-property-page.md"])
conn (d/create-conn db-schema/schema-for-db-based-graph)
_ (d/transact! conn (sqlite-create-graph/build-db-initial-data "{}"))
notifications (atom [])
_ (import-files-to-db files conn {:tag-classes ["123"]
:notify-user #(swap! notifications conj %)})]
(is (= [:error :error] (map :level @notifications))
"Error notifications for both invalid property and class")
(is (some #(re-find #"invalid class" %) (map :msg @notifications))
"Helpful message for invalid class")
(is (some #(re-find #"invalid property" %) (map :msg @notifications))
"Helpful message for invalid property")))
(deftest-async export-files-with-property-classes-option
(p/let [file-graph-dir "test/resources/exporter-test-graph"
files (mapv #(node-path/join file-graph-dir %) ["journals/2024_02_23.md" "pages/url.md"])