clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-06-01 19:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add back disallowing adding hidden built-in properties

Browse Source 
Without this adding a built in prop and value leads to it disappearing
with no explanation. Also cleaned up gp-property into sections mostly
to differentiate between file and db graph properties
This commit is contained in:
Gabriel Horner
2023-08-03 10:11:23 -04:00
parent 99ecf6cd42
commit 47cea36e7d
2 changed files with 57 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/frontend/components/property.cljs
View File

@@ -16,7 +16,6 @@
[clojure.string :as string]
[goog.dom :as gdom]
[frontend.search :as search]
[frontend.components.search.highlight :as highlight]
[frontend.components.svg :as svg]
[frontend.modules.shortcut.core :as shortcut]
[frontend.components.select :as select]
@@ -330,8 +329,7 @@
(set))
properties (->> (search/get-all-properties)
(remove entity-properties)
(remove (->> (set/difference gp-property/db-built-in-properties-keys
gp-property/db-user-facing-built-in-properties)
(remove (->> gp-property/db-hidden-built-in-properties
(map name)
set)))
get-property-f (fn [name]
@@ -353,11 +351,15 @@
:dropdown? true
:show-new-when-not-exact-match? true
:input-default-placeholder "Add a property"
:on-chosen (fn [{:keys [value] :as opts}]
:on-chosen (fn [{:keys [value]}]
(reset! *property-key value)
(if-let [property (get-property-f value)]
(let [editor-id (str "ls-property-" blocks-container-id (:db/id entity) "-" (:db/id property))]
(set-editing! property editor-id "" ""))
(if (contains? gp-property/db-hidden-built-in-properties (keyword value))
(do (notification/show! "This is a built-in property that can't be used." :error)
(reset! *property-key nil)
(exit-edit-property))
(let [editor-id (str "ls-property-" blocks-container-id (:db/id entity) "-" (:db/id property))]
(set-editing! property editor-id "" "")))
(do
(db-property/upsert-property! repo value {:type :default} {})
;; configure new property