From a18afc62f81d051c49e77737ea6c1d4f51cc1f1d Mon Sep 17 00:00:00 2001 From: Gabriel Horner Date: Wed, 9 Apr 2025 09:00:54 -0400 Subject: [PATCH 01/10] fix: shui/button triggers double-click when Enter is pressed Follow up to 6cb93386ae5808c63e79e3e135e639eb40234bfd which only fixed it for one button --- deps/shui/src/logseq/shui/base/core.cljs | 11 ++--------- src/main/frontend/components/property/config.cljs | 1 - 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/deps/shui/src/logseq/shui/base/core.cljs b/deps/shui/src/logseq/shui/base/core.cljs index 687ca82d24..61175a4fc5 100644 --- a/deps/shui/src/logseq/shui/base/core.cljs +++ b/deps/shui/src/logseq/shui/base/core.cljs @@ -39,16 +39,9 @@ [& props-and-children] (let [props (first props-and-children) children (rest props-and-children) - on-key-up' (:on-key-up props) children (if (map? props) children (cons props children)) - props (assoc (if (map? props) props {}) - :on-key-up (fn [^js e] - ;; If on-key-up is provided, it should be able to control Enter behavior - (if (fn? on-key-up') - (on-key-up' e) - (when (= "Enter" (.-key e)) - (some-> (.-target e) (.click))))))] - (apply button-base props children))) + props' (if (map? props) props {})] + (apply button-base props' children))) (defn button-icon [variant icon-name {:keys [icon-props size] :as props} child] diff --git a/src/main/frontend/components/property/config.cljs b/src/main/frontend/components/property/config.cljs index 251bded8ca..41bb7250f9 100644 --- a/src/main/frontend/components/property/config.cljs +++ b/src/main/frontend/components/property/config.cljs @@ -234,7 +234,6 @@ (let [dirty? (not= (rum/deref *form-data) form-data)] (shui/button {:size "sm" :disabled (not dirty?) - :on-key-up util/stop :on-click (fn [] (-> ( form-data uuid (assoc :id uuid))) From bd945b2408a9d74bf67ef422c81fcecc893d2d30 Mon Sep 17 00:00:00 2001 From: Gabriel Horner Date: Wed, 9 Apr 2025 09:00:54 -0400 Subject: [PATCH 02/10] fix: shui/button triggers double-click when Enter is pressed Follow up to 6cb93386ae5808c63e79e3e135e639eb40234bfd which only fixed it for one button --- deps/shui/src/logseq/shui/base/core.cljs | 11 ++--------- src/main/frontend/components/property/config.cljs | 1 - 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/deps/shui/src/logseq/shui/base/core.cljs b/deps/shui/src/logseq/shui/base/core.cljs index 687ca82d24..61175a4fc5 100644 --- a/deps/shui/src/logseq/shui/base/core.cljs +++ b/deps/shui/src/logseq/shui/base/core.cljs @@ -39,16 +39,9 @@ [& props-and-children] (let [props (first props-and-children) children (rest props-and-children) - on-key-up' (:on-key-up props) children (if (map? props) children (cons props children)) - props (assoc (if (map? props) props {}) - :on-key-up (fn [^js e] - ;; If on-key-up is provided, it should be able to control Enter behavior - (if (fn? on-key-up') - (on-key-up' e) - (when (= "Enter" (.-key e)) - (some-> (.-target e) (.click))))))] - (apply button-base props children))) + props' (if (map? props) props {})] + (apply button-base props' children))) (defn button-icon [variant icon-name {:keys [icon-props size] :as props} child] diff --git a/src/main/frontend/components/property/config.cljs b/src/main/frontend/components/property/config.cljs index 71535fe731..939317a404 100644 --- a/src/main/frontend/components/property/config.cljs +++ b/src/main/frontend/components/property/config.cljs @@ -234,7 +234,6 @@ (let [dirty? (not= (rum/deref *form-data) form-data)] (shui/button {:size "sm" :disabled (not dirty?) - :on-key-up util/stop :on-click (fn [] (-> ( form-data uuid (assoc :id uuid))) From 3f091940b4e9c05ee505475207049087979abfde Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Thu, 10 Apr 2025 13:33:06 +0800 Subject: [PATCH 03/10] fix: right-click on right-sidebar item's title part redirects --- src/main/frontend/components/block.cljs | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/main/frontend/components/block.cljs b/src/main/frontend/components/block.cljs index 1153d9365a..e5964f05f3 100644 --- a/src/main/frontend/components/block.cljs +++ b/src/main/frontend/components/block.cljs @@ -676,7 +676,8 @@ (editor-handler/block->data-transfer! page-name e true)) :on-mouse-over #(reset! *hover? true) :on-mouse-leave #(reset! *hover? false) - :on-click (fn [e] (when stop-click-event? (util/stop e))) + :on-click (fn [e] + (when stop-click-event? (util/stop e))) :on-pointer-down (fn [^js e] (cond (and meta-click? (util/meta-key? e)) @@ -695,7 +696,8 @@ :on-pointer-up (fn [e] (when @*mouse-down? (state/clear-edit!) - (when-not (:disable-click? config) + (when-not (or (:disable-click? config) + (:disable-redirect? config)) (open-page-ref config page-entity e page-name contents-page?)) (reset! *mouse-down? false))) :on-key-up (fn [e] (when (and e (= (.-key e) "Enter") (not meta-click?)) @@ -3092,7 +3094,9 @@ (rum/defc breadcrumb-fragment [config block label opts] - [:a {:on-pointer-up + [:a {:on-pointer-down (fn [e] + (when (some? (:sidebar-key config)) (util/stop e))) + :on-pointer-up (fn [e] (cond (gobj/get e "shiftKey") @@ -3109,13 +3113,7 @@ (reset! (:navigating-block opts) (:block/uuid block))) (some? (:sidebar-key config)) - (do - (util/stop e) - (state/sidebar-replace-block! - (:sidebar-key config) - [(state/get-current-repo) - (:db/id block) - (if (:block/name block) :page :block)])) + nil :else (when-let [uuid (:block/uuid block)] @@ -3148,7 +3146,11 @@ parents) more? (> (count parents) level-limit) parents (if more? (take-last level-limit parents) parents) - config (assoc config :breadcrumb? true)] + config (assoc config + :breadcrumb? true + :disable-redirect? true + :disable-preview? true + :stop-click-event? false)] (when show? (let [page-name-props (when show-page? [page From f3c42fa972f355bfdc59afb37874647473f8eaec Mon Sep 17 00:00:00 2001 From: charlie Date: Thu, 10 Apr 2025 17:05:36 +0800 Subject: [PATCH 04/10] fix(electron): invalid copy file for the file based graph --- src/main/frontend/handler/editor.cljs | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/main/frontend/handler/editor.cljs b/src/main/frontend/handler/editor.cljs index cc23104456..9b8b4ecc86 100644 --- a/src/main/frontend/handler/editor.cljs +++ b/src/main/frontend/handler/editor.cljs @@ -1435,16 +1435,18 @@ (string/replace #"^[.\/\\]*assets[\/\\]+" "")) dir (or (:dir matched-alias) repo-dir)] (if (util/electron?) - (let [from (not-empty (.-path file))] - (js/console.debug "Debug: Copy Asset #" dir file-rpath from) - (-> (js/window.apis.copyFileToAssets dir file-rpath from) - (p/then - (fn [dest] - [file-rpath - (if (string? dest) (js/File. #js[] dest) file) - (path/path-join dir file-rpath) - matched-alias])) - (p/catch #(js/console.error "Debug: Copy Asset Error#" %)))) + (do (js/console.debug "Debug: Copy Asset #" dir file-rpath) + (-> (if-let [from (not-empty (.-path file))] + (js/window.apis.copyFileToAssets dir file-rpath from) + (p/let [content (.arrayBuffer file)] + (fs/write-file! repo repo-dir file-rpath content {:skip-compare? true}))) + (p/then + (fn [dest] + [file-rpath + (if (string? dest) (js/File. #js[] dest) file) + (path/path-join dir file-rpath) + matched-alias])) + (p/catch #(js/console.error "Debug: Copy Asset Error#" %)))) (-> (p/do! (js/console.debug "Debug: Writing Asset #" dir file-rpath) From 4f26956ce7396d36fc38703182178b10b3a2ea09 Mon Sep 17 00:00:00 2001 From: charlie Date: Thu, 10 Apr 2025 18:13:33 +0800 Subject: [PATCH 05/10] fix(pdf): open pdf file --- src/main/frontend/extensions/pdf/assets.cljs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/frontend/extensions/pdf/assets.cljs b/src/main/frontend/extensions/pdf/assets.cljs index 5b3c560d93..cdf9d8fe86 100644 --- a/src/main/frontend/extensions/pdf/assets.cljs +++ b/src/main/frontend/extensions/pdf/assets.cljs @@ -43,11 +43,12 @@ [original-path & {:keys [href block]}] (let [web-link? (string/starts-with? original-path "http") blob-res? (some-> href (string/starts-with? "blob")) + asset-res? (some-> href (string/starts-with? "assets")) filename (util/node-path.basename original-path) ext-name "pdf" url (if blob-res? href (assets-handler/normalize-asset-resource-url original-path)) - filename' (if (or web-link? blob-res?) filename + filename' (if (or asset-res? web-link? blob-res?) filename (some-> (get-in-repo-assets-full-filename url) (js/decodeURIComponent) (string/replace '"/" "_"))) filekey (util/safe-sanitize-file-name From 25cbf32bd004d533d219e30e4b9329e9ccc0bc06 Mon Sep 17 00:00:00 2001 From: charlie Date: Thu, 10 Apr 2025 18:14:35 +0800 Subject: [PATCH 06/10] fix(pdf): react warning for the pdf region hls container --- src/main/frontend/extensions/pdf/core.cljs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/frontend/extensions/pdf/core.cljs b/src/main/frontend/extensions/pdf/core.cljs index eb562ade5f..58be7503b0 100644 --- a/src/main/frontend/extensions/pdf/core.cljs +++ b/src/main/frontend/extensions/pdf/core.cljs @@ -688,15 +688,15 @@ (when-let [grouped-hls (and (sequential? highlights) (group-by :page highlights))] (doseq [page loaded-pages] (when-let [^js/HTMLDivElement hls-layer (pdf-utils/resolve-hls-layer! viewer page)] - (let [page-hls (get grouped-hls page)] - - (rum/mount - (pdf-highlights-region-container - viewer page-hls {:show-ctx-menu! show-ctx-menu! - :upd-hl! upd-hl!}) - - hls-layer))))) - + (let [page-hls (get grouped-hls page) + hls-render (pdf-highlights-region-container + viewer page-hls {:show-ctx-menu! show-ctx-menu! + :upd-hl! upd-hl!}) + ^js mounted-root (.-mountedRoot hls-layer)] + (if (nil? mounted-root) + (->> (rum/mount hls-render hls-layer) + (set! (. hls-layer -mountedRoot))) + (.render mounted-root hls-render)))))) ;; destroy #()) [loaded-pages highlights]) From ff40821994dc386015c99eb58536b3de1db9ef79 Mon Sep 17 00:00:00 2001 From: rcmerci Date: Thu, 10 Apr 2025 19:21:36 +0800 Subject: [PATCH 07/10] feat(rtc): add property :logseq.property/created-by-ref --- deps/db/src/logseq/db/frontend/property.cljs | 10 +++++----- deps/db/src/logseq/db/frontend/schema.cljs | 2 +- .../graph-parser/src/logseq/graph_parser/block.cljs | 8 +++++++- deps/outliner/src/logseq/outliner/core.cljs | 10 +++++++--- src/main/frontend/handler/common/page.cljs | 7 +++---- src/main/frontend/handler/editor.cljs | 5 ++--- src/main/frontend/handler/user.cljs | 13 +++++++++++++ src/main/frontend/worker/db/migrate.cljs | 3 ++- src/main/frontend/worker/handler/page.cljs | 2 +- 9 files changed, 41 insertions(+), 19 deletions(-) diff --git a/deps/db/src/logseq/db/frontend/property.cljs b/deps/db/src/logseq/db/frontend/property.cljs index d5e440fce5..c1e9e69b1b 100644 --- a/deps/db/src/logseq/db/frontend/property.cljs +++ b/deps/db/src/logseq/db/frontend/property.cljs @@ -548,12 +548,12 @@ :logseq.property.history/scalar-value {:title "History scalar value" :schema {:type :any :hide? true}} - :logseq.property/created-by {:title "Node created by" - :schema {;; user-uuid, why not ref? - ;; - avoid losing this attr when the user-block is deleted - ;; - related user-block maybe not exists yet in graph - :type :string + :logseq.property/created-by {:title "Node created by(deprecated)" + :schema {:type :string :hide? true}} + :logseq.property/created-by-ref {:title "Node created by" + :schema {:type :entity + :hide? true}} :logseq.property/used-template {:title "Used template" :schema {:type :node :public? false diff --git a/deps/db/src/logseq/db/frontend/schema.cljs b/deps/db/src/logseq/db/frontend/schema.cljs index c950914ffd..af87b318cc 100644 --- a/deps/db/src/logseq/db/frontend/schema.cljs +++ b/deps/db/src/logseq/db/frontend/schema.cljs @@ -37,7 +37,7 @@ (map (juxt :major :minor) [(parse-schema-version x) (parse-schema-version y)]))) -(def version (parse-schema-version "64.3")) +(def version (parse-schema-version "64.4")) (defn major-version "Return a number. diff --git a/deps/graph-parser/src/logseq/graph_parser/block.cljs b/deps/graph-parser/src/logseq/graph_parser/block.cljs index 14a2e01635..e132eadac0 100644 --- a/deps/graph-parser/src/logseq/graph_parser/block.cljs +++ b/deps/graph-parser/src/logseq/graph_parser/block.cljs @@ -374,6 +374,11 @@ `skip-existing-page-check?`: if true, allows pages to have the same name" [original-page-name db with-timestamp? date-formatter & {:keys [page-uuid class? created-by] :as options}] + (assert (or (nil? created-by) + (and (map? created-by) + (:block/uuid created-by) + (:logseq.property.user/name created-by))) + created-by) (when-not (and db (common-util/uuid-string? original-page-name) (not (ldb/page? (d/entity db [:block/uuid (uuid original-page-name)])))) (let [db-based? (ldb/db-based-graph? db) @@ -400,7 +405,8 @@ (or (:block/tags page) [:logseq.class/Page]))] (cond-> (assoc page :block/tags tags) - created-by (assoc :logseq.property/created-by created-by))) + created-by + (assoc :logseq.property/created-by-ref created-by))) (assoc page :block/type (or (:block/type page) "page"))))))) (defn- db-namespace-page? diff --git a/deps/outliner/src/logseq/outliner/core.cljs b/deps/outliner/src/logseq/outliner/core.cljs index 6979b764e3..d30778815f 100644 --- a/deps/outliner/src/logseq/outliner/core.cljs +++ b/deps/outliner/src/logseq/outliner/core.cljs @@ -54,9 +54,13 @@ (defn- update-property-created-by [block created-by] + (assert (and (map? created-by) + (:block/uuid created-by) + (:logseq.property.user/name created-by)) + created-by) (cond-> block - (and created-by (nil? (:logseq.property/created-by block))) - (assoc :logseq.property/created-by created-by))) + (and created-by (nil? (:logseq.property/created-by-ref block))) + (assoc :logseq.property/created-by-ref created-by))) (defn- filter-top-level-blocks [db blocks] @@ -656,7 +660,7 @@ `replace-empty-target?`: If the `target-block` is an empty block, whether to replace it, it defaults to be `false`. `update-timestamps?`: whether to update `blocks` timestamps. - `created-by`: user-uuid, update `:logseq.property/created-by` if exists + `created-by`: user-block, update `:logseq.property/created-by-ref` if exists ``" [repo conn blocks target-block {:keys [_sibling? keep-uuid? keep-block-order? outliner-op replace-empty-target? update-timestamps? diff --git a/src/main/frontend/handler/common/page.cljs b/src/main/frontend/handler/common/page.cljs index 9bb0d73e72..a706cee0dc 100644 --- a/src/main/frontend/handler/common/page.cljs +++ b/src/main/frontend/handler/common/page.cljs @@ -60,13 +60,12 @@ (if (and has-tags? (nil? title')) (notification/show! "Page name can't include \"#\"." :warning) (when-not (string/blank? title') - (p/let [current-user-id (user/user-uuid) - options' (if db-based? + (p/let [options' (if db-based? (cond-> (update options :tags concat (:block/tags parsed-result)) (nil? (:split-namespace? options)) (assoc :split-namespace? true) - current-user-id - (assoc :created-by current-user-id)) + true + (assoc :created-by (user/user-block))) options) [_page-name page-uuid] (ui-outliner-tx/transact! {:outliner-op :create-page} diff --git a/src/main/frontend/handler/editor.cljs b/src/main/frontend/handler/editor.cljs index 9b8b4ecc86..6762d63fa5 100644 --- a/src/main/frontend/handler/editor.cljs +++ b/src/main/frontend/handler/editor.cljs @@ -335,8 +335,7 @@ true :else - (not has-children?)) - current-user-id (user/user-uuid)] + (not has-children?))] (ui-outliner-tx/transact! {:outliner-op :insert-blocks} (save-current-block! {:current-block current-block}) @@ -344,7 +343,7 @@ :keep-uuid? keep-uuid? :ordered-list? ordered-list? :replace-empty-target? replace-empty-target? - :created-by current-user-id})))) + :created-by (user/user-block)})))) (defn- block-self-alone-when-insert? [config uuid] diff --git a/src/main/frontend/handler/user.cljs b/src/main/frontend/handler/user.cljs index 413483122a..28f644aac5 100644 --- a/src/main/frontend/handler/user.cljs +++ b/src/main/frontend/handler/user.cljs @@ -85,6 +85,19 @@ parse-jwt :sub)) +(defn user-block + "FIXME: move to somewhere else?" + [] + (when-let [user-uuid* (user-uuid)] + (let [user-name (username) + email* (email)] + {:block/uuid (uuid user-uuid*) + :block/name user-name + :block/title user-name + :block/tags :logseq.class/Page + :logseq.property.user/name user-name + :logseq.property.user/email email*}))) + (defn logged-in? [] (some? (state/get-auth-refresh-token))) diff --git a/src/main/frontend/worker/db/migrate.cljs b/src/main/frontend/worker/db/migrate.cljs index d631388e26..7b69aa0f31 100644 --- a/src/main/frontend/worker/db/migrate.cljs +++ b/src/main/frontend/worker/db/migrate.cljs @@ -757,7 +757,8 @@ ["64.2" {:properties [:logseq.property.view/feature-type] :fix migrate-views}] ["64.3" {:properties [:logseq.property/used-template :logseq.property/template-applied-to] - :classes [:logseq.class/Template]}]]) + :classes [:logseq.class/Template]}] + ["64.4" {:properties [:logseq.property/created-by-ref]}]]) (let [[major minor] (last (sort (map (comp (juxt :major :minor) db-schema/parse-schema-version first) schema-version->updates))) diff --git a/src/main/frontend/worker/handler/page.cljs b/src/main/frontend/worker/handler/page.cljs index 39982d40c0..fd698094d3 100644 --- a/src/main/frontend/worker/handler/page.cljs +++ b/src/main/frontend/worker/handler/page.cljs @@ -34,7 +34,7 @@ * :tags - tag uuids that are added to :block/tags * :persist-op? - when true, add an update-page op * :properties - properties to add to the page - * :created-by - when set, set :logseq.property/created-by, only for db-based-graphs + * :created-by - user-block, when set, set :logseq.property/created-by-ref, only for db-based-graphs TODO: Add other options" [repo conn config title & {:as options}] (if (ldb/db-based-graph? @conn) From 768b745a2630fe82691ccd04f9903f391a53d4e2 Mon Sep 17 00:00:00 2001 From: rcmerci Date: Thu, 10 Apr 2025 20:38:54 +0800 Subject: [PATCH 08/10] fix: skip nil created-by --- deps/outliner/src/logseq/outliner/core.cljs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deps/outliner/src/logseq/outliner/core.cljs b/deps/outliner/src/logseq/outliner/core.cljs index d30778815f..f67fd3605b 100644 --- a/deps/outliner/src/logseq/outliner/core.cljs +++ b/deps/outliner/src/logseq/outliner/core.cljs @@ -704,9 +704,9 @@ true (mapv block-with-timestamps) db-based? - (mapv #(-> % - (dissoc :block/properties) - (update-property-created-by created-by))))) + (mapv #(cond-> % + true (dissoc :block/properties) + created-by (update-property-created-by created-by))))) insert-opts {:sibling? sibling? :replace-empty-target? replace-empty-target? :keep-uuid? keep-uuid? From 74886f9fab9f5912627bdaffb0ddc38cac8927c8 Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Fri, 11 Apr 2025 09:11:06 +0800 Subject: [PATCH 09/10] enhance(ux): show block metadata when hovering on bullet --- deps/db/src/logseq/db/frontend/property.cljs | 3 +- src/main/frontend/components/block.cljs | 54 ++++++++++++-------- 2 files changed, 34 insertions(+), 23 deletions(-) diff --git a/deps/db/src/logseq/db/frontend/property.cljs b/deps/db/src/logseq/db/frontend/property.cljs index c1e9e69b1b..5811493518 100644 --- a/deps/db/src/logseq/db/frontend/property.cljs +++ b/deps/db/src/logseq/db/frontend/property.cljs @@ -553,7 +553,8 @@ :hide? true}} :logseq.property/created-by-ref {:title "Node created by" :schema {:type :entity - :hide? true}} + :hide? true} + :queryable? true} :logseq.property/used-template {:title "Used template" :schema {:type :node :public? false diff --git a/src/main/frontend/components/block.cljs b/src/main/frontend/components/block.cljs index 8dc3b98eb1..0b1637cb78 100644 --- a/src/main/frontend/components/block.cljs +++ b/src/main/frontend/components/block.cljs @@ -2151,30 +2151,40 @@ (assoc :class "selected")) (when order-list? - [:label (str order-list-idx ".")])])]]] - (cond - (and (or (mobile-util/native-platform?) - (:ui/show-empty-bullets? (state/get-config)) - collapsed? - collapsable? - (< (- (util/time-ms) (:block/created-at block)) 500)) - (not doc-mode?)) - bullet + [:label (str order-list-idx ".")])])]] + bullet' (cond + (and (or (mobile-util/native-platform?) + (:ui/show-empty-bullets? (state/get-config)) + collapsed? + collapsable? + (< (- (util/time-ms) (:block/created-at block)) 500)) + (not doc-mode?)) + bullet - (or - (and empty-content? - (not edit?) - (not (:block.temp/top? block)) - (not (:block.temp/bottom? block)) - (not (util/react *control-show?)) - (not (:logseq.property/created-from-property block))) - (and doc-mode? - (not collapsed?) - (not (util/react *control-show?)))) - [:span.bullet-container] + (or + (and empty-content? + (not edit?) + (not (:block.temp/top? block)) + (not (:block.temp/bottom? block)) + (not (util/react *control-show?)) + (not (:logseq.property/created-from-property block))) + (and doc-mode? + (not collapsed?) + (not (util/react *control-show?)))) + [:span.bullet-container] - :else - bullet)))])) + :else + bullet)] + (if (config/db-based-graph?) + (ui/tippy + {:html (fn [] + [:div.flex.flex-col.gap-1.p-2 + (when-let [created-by (and (ldb/get-graph-rtc-uuid (db/get-db)) (:logseq.property/created-by-ref block))] + [:div (:block/title created-by)]) + [:div "Created: " (date/int->local-time-2 (:block/created-at block))] + [:div "Last edited: " (date/int->local-time-2 (:block/updated-at block))]])} + bullet') + bullet')))])) (rum/defc dnd-separator [move-to block-content?] From 1f39afb6ca76611f52320ad053dd3f15b84ec0ed Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Fri, 11 Apr 2025 09:22:51 +0800 Subject: [PATCH 10/10] fix: lint --- src/main/frontend/components/block.cljs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/frontend/components/block.cljs b/src/main/frontend/components/block.cljs index cadc455d1d..24104e271f 100644 --- a/src/main/frontend/components/block.cljs +++ b/src/main/frontend/components/block.cljs @@ -2100,7 +2100,7 @@ [block] (string/blank? (:block/title block))) -(rum/defcs block-control < rum/reactive +(rum/defcs ^:large-vars/cleanup-todo block-control < rum/reactive [state config block {:keys [uuid block-id collapsed? *control-show? edit? selected? top? bottom?]}] (let [doc-mode? (state/sub :document/mode?) control-show? (util/react *control-show?)