clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-04 19:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: editor no need to store the last-edit-block

Browse Source
This commit is contained in:
Tienson Qin
2020-10-28 20:42:39 +08:00
parent 51dfe14314
commit 8f09954691
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/frontend/handler/editor.cljs
View File

@@ -42,9 +42,6 @@
[frontend.handler.repeated :as repeated]
[clojure.core.async :as async]))
;; TODO: refactor the state, it is already too complex.
(defonce *last-edit-block (atom nil))
;; FIXME: should support multiple images concurrently uploading
(defonce *image-uploading? (atom false))
(defonce *image-uploading-process (atom 0))
@@ -57,10 +54,6 @@
[[:db/add (:db/id page) :page/last-modified-at modified-at]
[:db/add (:db/id file) :file/last-modified-at modified-at]]))
(defn set-last-edit-block!
[id value]
(reset! *last-edit-block [id value]))
(defn- get-selection-and-format
[]
(when-let [block (state/get-edit-block)]
@@ -741,7 +734,6 @@
last-child (when (not= (:block/uuid last-child)
(:block/uuid block))
last-child)]
(set-last-edit-block! (:block/uuid block) value)
;; save the current block and insert a new block
(insert-new-block-aux!
(or last-child block)
@@ -1291,10 +1283,8 @@
(assoc properties new-marker (util/time-ms))
properties)]
(let [cache [(:block/uuid block) value]]
(when (not= @*last-edit-block cache)
(save-block-if-changed! block new-value
{:custom-properties properties})
(reset! *last-edit-block cache))))))
(save-block-if-changed! block new-value
{:custom-properties properties})))))
(defn on-up-down
[state e up?]
@@ -1583,7 +1573,6 @@
(util/uuid-string? (get config :id)))
(<= final-level start-level)))
(<= (- final-level previous-level) 1))
(set-last-edit-block! (:block/uuid block) value)
(save-block-if-changed! block new-value
{:indent-left? (= direction :left)}))))]
;; TODO: Not a universal solution