From 94f2cbc5f66b2c7e100db301a1cde76e52184b65 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Tue, 5 May 2026 12:41:19 +0000
Subject: [PATCH] fix: delete old mirror path on rename when new path content
 is unchanged

Agent-Logs-Url: https://github.com/logseq/logseq/sessions/9db79397-9189-4b9b-a75c-ec333a6ca7b5

Co-authored-by: tiensonqin <479169+tiensonqin@users.noreply.github.com>
---
 src/main/frontend/worker/markdown_mirror.cljs |  4 ++-
 .../frontend/worker/markdown_mirror_test.cljs | 27 +++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/src/main/frontend/worker/markdown_mirror.cljs b/src/main/frontend/worker/markdown_mirror.cljs
index a2b1121c62..c5e61c8c4e 100644
--- a/src/main/frontend/worker/markdown_mirror.cljs
+++ b/src/main/frontend/worker/markdown_mirror.cljs
@@ -314,7 +314,9 @@
             _ (when (and old-path
                          new-path
                          (not= old-path new-path)
-                         (= :written (:status result)))
+                         (or (= :written (:status result))
+                             (and (= :skipped (:status result))
+                                  (= :unchanged (:reason result)))))
                 (<delete-file! platform* old-path))]
       result)))
 
diff --git a/src/test/frontend/worker/markdown_mirror_test.cljs b/src/test/frontend/worker/markdown_mirror_test.cljs
index d0a0277629..7da9448006 100644
--- a/src/test/frontend/worker/markdown_mirror_test.cljs
+++ b/src/test/frontend/worker/markdown_mirror_test.cljs
@@ -368,6 +368,33 @@
           (p/catch (fn [e] (is false (str "unexpected error: " e))))
           (p/finally done)))))
 
+(deftest rename-with-unchanged-content-removes-old-mirror-path-test
+  (async done
+    (let [{:keys [platform files deletes]} (fake-platform)
+          page-uuid #uuid "55555555-5555-4555-8555-555555555556"
+          conn (db-test/create-conn-with-blocks
+                {:pages-and-blocks [{:page {:block/title "Old Name2"
+                                             :block/uuid page-uuid}
+                                     :blocks [{:block/title "body"}]}]})
+          page (db-test/find-page-by-title @conn "Old Name2")
+          old-path (page-path "pages/Old Name2.md")
+          new-path (page-path "pages/New Name2.md")
+          ;; pre-populate both old and new paths with same content
+          _ (swap! files assoc old-path "- body")
+          _ (swap! files assoc new-path "- body")
+          tx-report (d/with @conn [{:db/id (:db/id page)
+                                    :block/title "New Name2"
+                                    :block/name "new name2"}])
+          _ (d/reset-conn! conn (:db-after tx-report))]
+      (markdown-mirror/set-enabled! test-repo true)
+      (-> (markdown-mirror/<handle-tx-report! test-repo conn tx-report {:platform platform})
+          (p/then (fn [_]
+                    ;; old-path must be cleaned up even though new-path was unchanged
+                    (is (= [old-path] @deletes))
+                    (is (nil? (get @files old-path)))))
+          (p/catch (fn [e] (is false (str "unexpected error: " e))))
+          (p/finally done)))))
+
 (deftest delete-removes-mirror-file-test
   (async done
     (let [{:keys [platform files deletes writes]} (fake-platform)