From 1849d7a96a5ee96aac07301101ef6bc564230a46 Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Tue, 9 Sep 2025 16:29:19 +0800 Subject: [PATCH 1/2] fix: show tag's extends when auto-complete or setting extends fixes https://github.com/logseq/db-test/issues/466 --- deps/db/src/logseq/db.cljs | 2 ++ deps/db/src/logseq/db/frontend/db.cljs | 6 ++--- .../frontend/components/property/value.cljs | 22 +++++++++---------- src/main/frontend/handler/block.cljs | 7 +++++- 4 files changed, 22 insertions(+), 15 deletions(-) diff --git a/deps/db/src/logseq/db.cljs b/deps/db/src/logseq/db.cljs index 0ece199ba5..d957dd8d83 100644 --- a/deps/db/src/logseq/db.cljs +++ b/deps/db/src/logseq/db.cljs @@ -594,3 +594,5 @@ true :else (recur (:block/parent parent))))))) + +(def get-class-title-with-extends db-db/get-class-title-with-extends) diff --git a/deps/db/src/logseq/db/frontend/db.cljs b/deps/db/src/logseq/db/frontend/db.cljs index f72bfb0971..cdc754f89e 100644 --- a/deps/db/src/logseq/db/frontend/db.cljs +++ b/deps/db/src/logseq/db/frontend/db.cljs @@ -55,14 +55,14 @@ (conj parents' current-parent)) (vec (reverse parents')))))) -(defn- get-class-title-with-extends +(defn get-class-title-with-extends [entity] (let [parents' (->> (db-class/get-class-extends entity) (remove (fn [e] (= :logseq.class/Root (:db/ident e)))) vec)] (string/join ns-util/parent-char - (map :block/title (conj (vec parents') entity))))) + (map :block/title (conj parents' entity))))) (defn get-title-with-parents [entity] @@ -131,4 +131,4 @@ (defn library? [page] (and (entity-util/built-in? page) - (= common-config/library-page-name (:block/title page)))) \ No newline at end of file + (= common-config/library-page-name (:block/title page)))) diff --git a/src/main/frontend/components/property/value.cljs b/src/main/frontend/components/property/value.cljs index 45f7284d18..8a5d9a688f 100644 --- a/src/main/frontend/components/property/value.cljs +++ b/src/main/frontend/components/property/value.cljs @@ -709,17 +709,17 @@ (remove (fn [e] (contains? exclude-ids (:block/uuid e)))))] excluded-options) - (contains? #{:class :property} property-type) - (let [classes (cond-> - (model/get-all-classes - repo - {:except-root-class? true - :except-private-tags? (not (contains? #{:logseq.property/template-applied-to} (:db/ident property)))}) - (not (or (and (entity-util/page? block) (not (ldb/internal-page? block))) (:logseq.property/created-from-property block))) - (conj (db/entity :logseq.class/Page)))] - (if (= property-type :class) - classes - (property-handler/get-class-property-choices))) + (= :class property-type) + (cond-> + (model/get-all-classes + repo + {:except-root-class? true + :except-private-tags? (not (contains? #{:logseq.property/template-applied-to} (:db/ident property)))}) + (not (or (and (entity-util/page? block) (not (ldb/internal-page? block))) (:logseq.property/created-from-property block))) + (conj (db/entity :logseq.class/Page))) + + (= :property property-type) + (property-handler/get-class-property-choices) (seq classes) (->> diff --git a/src/main/frontend/handler/block.cljs b/src/main/frontend/handler/block.cljs index 7acd4a9770..310dcd40d6 100644 --- a/src/main/frontend/handler/block.cljs +++ b/src/main/frontend/handler/block.cljs @@ -146,7 +146,11 @@ (or (some-> (:block/raw-title block-e) (ldb/inline-tag? t)) (ldb/private-tags (:db/ident t)))) (map (fn [tag] (if (number? tag) (db/entity tag) tag)) (:block/tags block)))] - (if (seq tags) + (cond + (ldb/class? block) + (ldb/get-class-title-with-extends block) + + (seq tags) (str (:block/title block) " " (string/join @@ -155,6 +159,7 @@ (when-let [title (:block/title tag)] (str "#" title))) tags))) + :else (:block/title block)))) (defn edit-block! From 1705025557d1d6b465c940badcc7dff5db45b334 Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Tue, 9 Sep 2025 17:46:04 +0800 Subject: [PATCH 2/2] rename db-worker-ready-promise to app-ready-promise --- src/main/frontend/handler.cljs | 2 +- src/main/frontend/state.cljs | 2 +- src/main/mobile/init.cljs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/frontend/handler.cljs b/src/main/frontend/handler.cljs index 9cc25a2f68..a5761c9343 100644 --- a/src/main/frontend/handler.cljs +++ b/src/main/frontend/handler.cljs @@ -179,7 +179,7 @@ (js/console.error "Error while restoring repos: " e))) (p/finally (fn [] (state/set-db-restoring! false) - (p/resolve! state/db-worker-ready-promise true) + (p/resolve! state/app-ready-promise true) (when-not (util/mobile?) (p/let [webgpu-available? (db-browser/