mirror of
https://github.com/logseq/logseq.git
synced 2026-02-01 22:47:36 +00:00
Fix remaining todos and add a section to practices about this new action
This commit is contained in:
committed by
Gabriel Horner
parent
25c15053d6
commit
b78c689458
@@ -77,6 +77,22 @@ error if it detects an invalid query.
|
||||
Our translations can be configured incorrectly. We can catch some of these
|
||||
mistakes [as noted here](./contributing-to-translations.md#fix-mistakes).
|
||||
|
||||
### Spell Checker
|
||||
|
||||
We use [typos](https://github.com/crate-ci/typos) to spell check our source code.
|
||||
|
||||
To install it locally and use it:
|
||||
|
||||
```sh
|
||||
$ brew install typos-cli
|
||||
# Catch any errors
|
||||
$ typos
|
||||
# Fix errors
|
||||
$ typos -w
|
||||
```
|
||||
|
||||
To configure it e.g. for dealing with false positives, see `typos.toml`.
|
||||
|
||||
## Testing
|
||||
|
||||
We have unit, performance and end to end tests.
|
||||
|
||||
@@ -78,12 +78,12 @@
|
||||
nil)]
|
||||
|
||||
[:div.text-sm.cursor
|
||||
{:title (str "Revision: " config/revison)
|
||||
{:title (str "Revision: " config/revision)
|
||||
:on-click (fn []
|
||||
(notification/show! [:div "Current Revision: "
|
||||
[:a {:target "_blank"
|
||||
:href (str "https://github.com/logseq/logseq/commit/" config/revison)}
|
||||
config/revison]]
|
||||
:href (str "https://github.com/logseq/logseq/commit/" config/revision)}
|
||||
config/revision]]
|
||||
:info
|
||||
false))}
|
||||
version]
|
||||
|
||||
@@ -17,7 +17,7 @@
|
||||
(defonce publishing? PUBLISHING)
|
||||
|
||||
(goog-define REVISION "unknown")
|
||||
(defonce revison REVISION)
|
||||
(defonce revision REVISION)
|
||||
|
||||
(reset! state/publishing? publishing?)
|
||||
|
||||
|
||||
@@ -18,8 +18,8 @@
|
||||
:environment (if config/dev? "development" "production")
|
||||
:initialScope {:tags
|
||||
(merge
|
||||
(when (not-empty config/revison)
|
||||
{:revision config/revison})
|
||||
(when (not-empty config/revision)
|
||||
{:revision config/revision})
|
||||
{:platform (cond
|
||||
(util/electron?) "electron"
|
||||
(mobile-util/native-platform?) "mobile"
|
||||
|
||||
12
typos.toml
12
typos.toml
@@ -1,14 +1,16 @@
|
||||
[default.extend-words]
|
||||
# Technical words
|
||||
edn = "edn"
|
||||
datas = "datas"
|
||||
BA = "BA"
|
||||
juxt = "juxt"
|
||||
Ded = "Ded" # Shows up in ANDed
|
||||
referer = "referer" # This is a misspelling in the http spec so not much we can do
|
||||
|
||||
# False positives
|
||||
collapsable = "collapsable" # This an ok alternative to collapsible
|
||||
BA = "BA"
|
||||
fo = "fo"
|
||||
collapsable = "collapsable" # TODO: should be collapsible
|
||||
Ded = "Ded"
|
||||
aks = "aks"
|
||||
Mannor = "Mannor"
|
||||
revison = "revison" # TODO: should be revision
|
||||
referer = "referer" # TODO: should be referrer
|
||||
[files]
|
||||
extend-exclude = ["resources/*", "templates/*", "dicts.cljc"]
|
||||
|
||||
Reference in New Issue
Block a user