clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-04-24 22:25:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

dev: update prompts/review.md

Browse Source
This commit is contained in:
rcmerci
2025-09-12 13:08:39 +08:00
parent a290ef004d
commit c2564469a2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
prompts/review.md
View File

@@ -6,8 +6,9 @@ You're Clojure(script) expert, you're responsible to check those common errors:
- If the arguments of `cljs-time.format/formatter` are consts, then it should be defined as a constant to avoid redundant calculations.
- Recommended to *avoid* using `memoize`, especially when the memoized function's parameters include `entity` or `block` or `conn` or `db`. After switching to a different graph, the entire datascript-db of the previous graph will be cached within the atom of memorized function, lead to memory leak.
- Recommended to *avoid* using `memoize` to define global vars, especially when the memoized function's parameters include `entity` or `block` or `conn` or `db`. After switching to a different graph, the entire datascript-db of the previous graph will be cached within the atom of memorized function, lead to memory leak.
- Avoid using `dorun` to execute side effects; `doseq` is recommended.
- `util/web-platform?` is a not a function.