clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-04-30 00:46:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong cursor posistion (#10838)

Browse Source 
* fix unable to use 'del' to delete the last character
if the cursor is at the beginning of the block

* fix right arrow calculate character length incorrect
if the cursor is at the beginning of the block

* fix moving up or down across blocks may enter the middle of a character

* fix moving up or down inside a block may enter the middle of a character
This commit is contained in:
megayu
2024-01-11 16:22:37 +08:00
committed by GitHub
parent a2bb7e4479
commit c25c432755
6 changed files with 96 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/test/frontend/util_test.cljs
View File

@@ -13,6 +13,7 @@
(is (= 3 (util/safe-dec-current-pos-from-end "abc😀d" 5)))
(is (= 3 (util/safe-dec-current-pos-from-end "abc😀" 5)))
(is (= 0 (util/safe-dec-current-pos-from-end "😀" 2)))
(is (= 0 (util/safe-dec-current-pos-from-end "a" 1)))
(is (= 4 (util/safe-dec-current-pos-from-end "abcde" 5)))
(is (= 1 (util/safe-dec-current-pos-from-end "中文" 2))))
@@ -20,8 +21,40 @@
(is (= 5 (util/safe-inc-current-pos-from-start "abc😀d" 3)))
(is (= 2 (util/safe-inc-current-pos-from-start "😀" 0)))
(is (= 2 (util/safe-inc-current-pos-from-start "abcde" 1)))
(is (= 1 (util/safe-inc-current-pos-from-start "a" 0)))
(is (= 1 (util/safe-inc-current-pos-from-start "中文" 0)))))
(deftest test-get-line-pos
(testing "get-line-pos"
(is (= 3 (util/get-line-pos "abcde" 3)))
(is (= 4 (util/get-line-pos "abcd\ne" 4)))
(is (= 0 (util/get-line-pos "abcd\ne" 5)))
(is (= 4 (util/get-line-pos "abc😀d" 5)))
(is (= 1 (util/get-line-pos "abc\nde" 5)))
(is (= 1 (util/get-line-pos "abc\n😀d" 6)))
(is (= 2 (util/get-line-pos "ab\nc😀d" 6)))
(is (= 1 (util/get-line-pos "abc\nde\nf" 5)))
(is (= 1 (util/get-line-pos "abc\n😀d\ne" 6)))
(is (= 2 (util/get-line-pos "ab\nc😀d\ne" 6)))))
(deftest test-get-text-range
(testing "get-text-range"
(is (= "" (util/get-text-range "abcdefg" 0 true)))
(is (= "" (util/get-text-range "abcdefg" 0 false)))
(is (= "abcdefg" (util/get-text-range "abcdefg" 10 true)))
(is (= "abcdefg" (util/get-text-range "abcdefg" 10 false)))
(is (= "abc" (util/get-text-range "abcdefg" 3 true)))
(is (= "abc" (util/get-text-range "abcdefg" 3 false)))
(is (= "abc" (util/get-text-range "abcdefg\nhijklmn" 3 true)))
(is (= "abcdefg\nhij" (util/get-text-range "abcdefg\nhijklmn" 3 false)))
(is (= "abcdefg\nhijklmn" (util/get-text-range "abcdefg\nhijklmn" 10 false)))
(is (= "abcdefg\nhijklmn\nopq" (util/get-text-range "abcdefg\nhijklmn\nopqrst" 3 false)))
(is (= "a😀b" (util/get-text-range "a😀bcdefg" 3 true)))
(is (= "a😀b" (util/get-text-range "a😀bcdefg" 3 false)))
(is (= "a😀b" (util/get-text-range "a😀bcdefg\nhijklmn" 3 true)))
(is (= "a😀bcdefg\nhij" (util/get-text-range "a😀bcdefg\nhijklmn" 3 false)))
(is (= "a😀bcdefg\nh😀i" (util/get-text-range "a😀bcdefg\nh😀ijklmn" 3 false)))))
(deftest test-memoize-last
(testing "memoize-last add test"
(let [actual-ops (atom 0)