clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-04 19:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugin): occasional memory leak when dynamic slot ui with provide ui

Browse Source
This commit is contained in:
charlie
2022-07-12 17:57:39 +08:00
committed by Tienson Qin
parent a93b47a886
commit cc04718576
3 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/frontend/components/plugins.cljs
View File

@@ -791,15 +791,23 @@
(rum/defc hook-ui-slot
([type payload] (hook-ui-slot type payload nil))
([type payload opts]
(let [rs (util/rand-str 8)
id (str "slot__" rs)]
(let [rs (util/rand-str 8)
id (str "slot__" rs)
*el-ref (rum/use-ref nil)]
(rum/use-effect!
(fn []
(plugin-handler/hook-plugin-app type {:slot id :payload payload} nil)
#())
(let [el (rum/deref *el-ref)]
(plugin-handler/hook-plugin-app type {:slot id :payload payload} nil)
#(when-let [uis (seq (.querySelectorAll el "[data-injected-ui]"))]
(doseq [^js el uis]
(when-let [id (.-injectedUi (.-dataset el))]
(js/LSPluginCore._forceCleanInjectedUI id))))))
[id])
[:div.lsp-hook-ui-slot
(merge opts {:id id
:ref *el-ref
:on-mouse-down (fn [e] (util/stop e))})])))
(rum/defc ui-item-renderer