mirror of
https://github.com/logseq/logseq.git
synced 2026-05-04 19:06:21 +00:00
enhance(dev): add linters and workflow for publish
to have basic code quality checks. Test worker asset builds successfully Also fix minor things caught by clj-kondo and carve.
This commit is contained in:
103
.github/workflows/deps-publish.yml
vendored
Normal file
103
.github/workflows/deps-publish.yml
vendored
Normal file
@@ -0,0 +1,103 @@
|
||||
name: logseq/publish CI
|
||||
|
||||
on:
|
||||
# Path filters ensure jobs only kick off if a change is made to publish or
|
||||
# its local dependencies
|
||||
push:
|
||||
branches: [master]
|
||||
paths:
|
||||
- 'deps/publish/**'
|
||||
- '.github/workflows/deps-publish.yml'
|
||||
- '!deps/publish/**.md'
|
||||
# Deps that logseq/publish depends on should trigger this workflow
|
||||
- 'deps/graph-parser/**'
|
||||
- 'deps/db/**'
|
||||
- 'deps/common/**'
|
||||
pull_request:
|
||||
branches: [master]
|
||||
paths:
|
||||
- 'deps/publish/**'
|
||||
- '.github/workflows/deps-publish.yml'
|
||||
- '!deps/publish/**.md'
|
||||
# Deps that logseq/publish depends on should trigger this workflow
|
||||
- 'deps/graph-parser/**'
|
||||
- 'deps/db/**'
|
||||
- 'deps/common/**'
|
||||
|
||||
defaults:
|
||||
run:
|
||||
working-directory: deps/publish
|
||||
|
||||
env:
|
||||
CLOJURE_VERSION: '1.11.1.1413'
|
||||
# This is the same as 1.8.
|
||||
JAVA_VERSION: '11'
|
||||
# This is the latest node version we can run.
|
||||
NODE_VERSION: '22'
|
||||
BABASHKA_VERSION: '1.0.168'
|
||||
|
||||
jobs:
|
||||
test-release:
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@v4
|
||||
|
||||
- name: Set up Node
|
||||
uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: ${{ env.NODE_VERSION }}
|
||||
cache: 'yarn'
|
||||
cache-dependency-path: deps/publish/yarn.lock
|
||||
|
||||
- name: Set up Java
|
||||
uses: actions/setup-java@v4
|
||||
with:
|
||||
distribution: 'zulu'
|
||||
java-version: ${{ env.JAVA_VERSION }}
|
||||
|
||||
# Clojure needed for bb step
|
||||
- name: Set up Clojure
|
||||
uses: DeLaGuardo/setup-clojure@10.1
|
||||
with:
|
||||
cli: ${{ env.CLOJURE_VERSION }}
|
||||
bb: ${{ env.BABASHKA_VERSION }}
|
||||
|
||||
- name: Fetch yarn deps
|
||||
run: yarn install --frozen-lockfile
|
||||
|
||||
- name: Build release asset
|
||||
run: yarn release
|
||||
|
||||
lint:
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@v4
|
||||
|
||||
- name: Set up Java
|
||||
uses: actions/setup-java@v4
|
||||
with:
|
||||
distribution: 'zulu'
|
||||
java-version: ${{ env.JAVA_VERSION }}
|
||||
|
||||
- name: Set up Clojure
|
||||
uses: DeLaGuardo/setup-clojure@10.1
|
||||
with:
|
||||
cli: ${{ env.CLOJURE_VERSION }}
|
||||
bb: ${{ env.BABASHKA_VERSION }}
|
||||
|
||||
- name: Run clj-kondo lint
|
||||
run: clojure -M:clj-kondo --lint src
|
||||
|
||||
- name: Carve lint for unused vars
|
||||
run: bb lint:carve
|
||||
|
||||
- name: Lint for vars that are too large
|
||||
run: bb lint:large-vars
|
||||
|
||||
# TODO: Add docstrings
|
||||
# - name: Lint for namespaces that aren't documented
|
||||
# run: bb lint:ns-docstrings
|
||||
Reference in New Issue
Block a user