From d19069021fba3d267acfc2666a04c101fa7276ba Mon Sep 17 00:00:00 2001
From: Gabriel Horner <gabriel@logseq.com>
Date: Tue, 31 Mar 2026 12:12:05 -0400
Subject: [PATCH] fix: lints and typos

---
 deps/db/src/logseq/db/common/normalize.cljs   | 16 ++++++-------
 .../src/logseq/outliner/property.cljs         | 23 +++++++++++--------
 .../067-logseq-cli-json-namespaced-keys.md    |  2 +-
 typos.toml                                    |  2 ++
 4 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/deps/db/src/logseq/db/common/normalize.cljs b/deps/db/src/logseq/db/common/normalize.cljs
index 693b9bf744..e097f08dfb 100644
--- a/deps/db/src/logseq/db/common/normalize.cljs
+++ b/deps/db/src/logseq/db/common/normalize.cljs
@@ -131,16 +131,16 @@
                        tx-data)]
     (concat retract-ops datoms-for-retracted-eids others)))
 
+(defn- added-title?
+  [d]
+  (when (= (count d) 5)
+    (let [[e a _v _t added] d]
+      (when (and added (= :block/title a))
+        e))))
+
 (defn normalize-tx-data
   [db-after db-before tx-data]
-  (let [title-updated-entities
-        (->> tx-data
-             (keep (fn [d]
-                     (when (= (count d) 5)
-                       (let [[e a _v _t added] d]
-                         (when (and added (= :block/title a))
-                           e)))))
-             set)]
+  (let [title-updated-entities (->> tx-data (keep added-title?) set)]
     (->> tx-data
          remove-conflict-datoms
          (replace-attr-retract-with-retract-entity db-after)
diff --git a/deps/outliner/src/logseq/outliner/property.cljs b/deps/outliner/src/logseq/outliner/property.cljs
index a43da4aa89..afddf40dc8 100644
--- a/deps/outliner/src/logseq/outliner/property.cljs
+++ b/deps/outliner/src/logseq/outliner/property.cljs
@@ -500,11 +500,20 @@
               (when (seq txs)
                 (transact-with-op! conn txs {:outliner-op :save-block})))))))))
 
+(defn- validate-batch-set-property
+  [conn block-eids property-id v]
+  (when (= property-id :block/tags)
+    (outliner-validate/validate-tags-property @conn block-eids v))
+  (when (= property-id :logseq.property.class/extends)
+    (outliner-validate/validate-extends-property
+     @conn
+     (if (number? v) (d/entity @conn v) v)
+     (map #(d/entity @conn %) block-eids))))
+
 (defn batch-set-property!
   "Sets properties for multiple blocks. Automatically handles property value refs.
-   Does no validation of property values.
-   For :many properties, passing a collection replaces existing values in one
-   call, while passing a scalar preserves add-single-value behavior."
+   Does no validation of property values. For :many properties, passing a collection
+   replaces existing values in one call, while passing a scalar preserves add-single-value behavior."
   ([conn block-ids property-id v]
    (batch-set-property! conn block-ids property-id v {}))
   ([conn block-ids property-id v options]
@@ -516,14 +525,8 @@
        (if (nil? v)
      (batch-remove-property! conn block-ids property-id)
      (let [block-eids (map ->eid block-ids)
-           _ (when (= property-id :block/tags)
-               (outliner-validate/validate-tags-property @conn block-eids v))
+           _ (validate-batch-set-property conn block-eids property-id v)
            property (d/entity @conn property-id)
-           _ (when (= (:db/ident property) :logseq.property.class/extends)
-               (outliner-validate/validate-extends-property
-                @conn
-                (if (number? v) (d/entity @conn v) v)
-                (map #(d/entity @conn %) block-eids)))
            _ (when (nil? property)
                (throw (ex-info (str "Property " property-id " doesn't exist yet") {:property-id property-id})))
            property-type (get property :logseq.property/type :default)
diff --git a/docs/agent-guide/067-logseq-cli-json-namespaced-keys.md b/docs/agent-guide/067-logseq-cli-json-namespaced-keys.md
index 9e75e54d32..b5f01f25fe 100644
--- a/docs/agent-guide/067-logseq-cli-json-namespaced-keys.md
+++ b/docs/agent-guide/067-logseq-cli-json-namespaced-keys.md
@@ -202,7 +202,7 @@ A payload map may contain multiple namespaced keys sharing the same leaf name ac
 
 Nested maps inside vectors and vectors inside maps must preserve key semantics recursively.
 
-Keyword values that are real user strings in data must not be mis-typed by the serializer.
+Keyword values that are real user strings in data must not be mistyped by the serializer.
 
 String keys containing `/` must remain unchanged and must not be reinterpreted as keywords.
 
diff --git a/typos.toml b/typos.toml
index fe38983621..1b2f55bc71 100644
--- a/typos.toml
+++ b/typos.toml
@@ -17,6 +17,8 @@ deleteable = "deleteable"
 fom = "fom"
 tne = "tne"
 Damon = "Damon"
+Ede = "Ede"
+
 [files]
 extend-exclude = ["resources/*",
                   "src/resources/*",