From da4beef34db1eb4ae7c610b1583fcb2708d4f6a8 Mon Sep 17 00:00:00 2001
From: Gabriel Horner <gabriel@logseq.com>
Date: Mon, 11 Sep 2023 17:16:36 -0400
Subject: [PATCH] enhance: clicking on properties navigates in publishing

Previously this did nothing since publishing is read only. This is
also more user friendly as clicking on a page normally navigates to it
---
 src/main/frontend/components/property.cljs | 29 +++++++++++++---------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/src/main/frontend/components/property.cljs b/src/main/frontend/components/property.cljs
index c7519fccdc..d6f431a3ae 100644
--- a/src/main/frontend/components/property.cljs
+++ b/src/main/frontend/components/property.cljs
@@ -19,7 +19,8 @@
             [frontend.ui :as ui]
             [frontend.util :as util]
             [logseq.db.property :as db-property]
-            [rum.core :as rum]))
+            [rum.core :as rum]
+            [frontend.handler.route :as route-handler]))
 
 (rum/defc icon
   [block {:keys [_type id]}]            ; only :emoji supported yet
@@ -334,18 +335,22 @@
       {:modal-class (util/hiccup->class
                      "origin-top-right.absolute.left-0.rounded-md.shadow-lg.mt-2")})
      (ui/dropdown
+      (if config/publishing?
+        (fn [_opts]
+          [:a.property-k
+           {:on-click #(route-handler/redirect-to-page! (:block/name property))}
+           [:div.ml-1 (:block/original-name property)]])
+        (fn [{:keys [toggle-fn]}]
+          [:a.property-k
+             {:data-propertyid (:block/uuid property)
+              :data-blockid (:block/uuid block)
+              :data-class-schema (boolean class-schema?)
+              :title (str "Configure property: " (:block/original-name property))
+              :on-click toggle-fn}
+             [:div.ml-1 (:block/original-name property)]]))
       (fn [{:keys [toggle-fn]}]
-        [:a.property-k
-         {:data-propertyid (:block/uuid property)
-          :data-blockid (:block/uuid block)
-          :data-class-schema (boolean class-schema?)
-          :title (str "Configure property: " (:block/original-name property))
-          :on-click toggle-fn}
-         [:div.ml-1 (:block/original-name property)]])
-      (fn [{:keys [toggle-fn]}]
-        (when (not config/publishing?)
-          [:div.p-8
-           (property-config repo property {:toggle-fn toggle-fn})]))
+        [:div.p-8
+         (property-config repo property {:toggle-fn toggle-fn})])
       {:modal-class (util/hiccup->class
                      "origin-top-right.absolute.left-0.rounded-md.shadow-lg")})]))