Tienson Qin
02fcc69928
CSS tweaks
2024-05-28 03:02:22 +08:00
Tienson Qin
21e480ec3e
fix: can't delete :checkbox property
2024-05-27 22:56:49 +08:00
Tienson Qin
c326730ce5
fix: retract icon property when settign a closed value's icon to nil
2024-05-27 12:30:45 +08:00
Gabriel Horner
77f14ca1f6
fix: don't delete property values while typing
...
property values were deleted while typing b/c
content ref re-calculation wasn't considering them.
Related to LOG-2819
2024-05-24 18:14:14 -04:00
Gabriel Horner
7c0b154fff
fix: disallow property self-refs
...
Causes wonky linked reference animations and maybe other
bugs. Can repro by creating a property url and then adding the :url
property as a page property to the url page
2024-05-24 14:03:16 -04:00
Gabriel Horner
0fc01b94a3
fix: tests
2024-05-23 09:45:38 -04:00
Tienson Qin
c118271fdd
refactor: property position support left/right/below
...
Removed the limitation that only properties with closed values can
have custom positions.
2024-05-23 20:48:04 +08:00
Tienson Qin
1cfc426486
enhance: properties ux
...
1. add icons to priorities
2. hide task properties so that blocks are not collapsable
3. block positions support end of block
2024-05-23 17:18:23 +08:00
Tienson Qin
c862ad0d10
refactor: db/transact! as outliner op
...
The benefits:
1. all db transactions from the UI thread can be described in outliner
ops now.
2. batch undo/redo
2024-05-23 05:16:51 +08:00
Gabriel Horner
8de74ce654
fix: lint for large var
2024-05-22 17:03:00 -04:00
Gabriel Horner
ceb3681cfe
fix: nbb scripts updates :block/refs the same as app
...
nbb was only handling path-refs previously. Can remove hacky
managing of refs in create-graph. Still a TODO to fix schema graph
lazy loading bug. Related to LOG-2819
2024-05-22 16:51:50 -04:00
Gabriel Horner
67ff14038a
enhance: add :config option to schema graph
...
also fix outliner lints
2024-05-22 13:37:40 -04:00
Tienson Qin
d298567737
fix: wrong arguments for delete-blocks
2024-05-23 00:35:22 +08:00
Tienson Qin
f218732b17
fix: property path-refs
...
1. :block/refs support to page properties
2. don't add built-in properties to refs
3. don't add current block or parents' other properties to :default blocks
2024-05-22 23:30:00 +08:00
Gabriel Horner
8b12e7f136
fix: property refs not calculating for file graphs
...
Fixes a bug where clicking a TODO in a file graph resulted in an error.
Bring back file graph implementation accidentally taken out in
d31b8cd5ae .
Also fixes related test
2024-05-22 10:42:44 -04:00
Gabriel Horner
04e71a9a23
Bump datascript for nbb-logseq
2024-05-22 09:37:16 -04:00
Tienson Qin
f944dd2de9
fix: can't add existing :many property
2024-05-22 07:55:18 +08:00
Gabriel Horner
cfe22e4acc
fix: lints
2024-05-21 16:14:05 -04:00
Gabriel Horner
fd5b90596b
chore: remove nonexistent fix-tx
2024-05-21 11:00:11 -04:00
Tienson Qin
67bd6c6da3
fix: build refs for either pages or tagged blocks (objects)
2024-05-21 21:05:02 +08:00
Tienson Qin
8d959a7c8b
chore: bump datascript
2024-05-21 20:51:22 +08:00
Tienson Qin
db8d0c53df
fix: datascript upsert db/ident
2024-05-21 19:29:21 +08:00
Tienson Qin
d31b8cd5ae
fix: add property named blocks values to :block/refs
...
related to LOG-2819
2024-05-21 16:35:39 +08:00
Tienson Qin
ee35854498
fix: delete property value block when it's not used by other blocks
2024-05-21 07:49:33 +08:00
Gabriel Horner
33832f7941
fix: property names with invalid idents display an error notification
...
instead of silently failing in console. E.g. `123` as a property name
2024-05-20 17:21:56 -04:00
Tienson Qin
e34af3412e
enhance: delay creating new property until type specified
2024-05-20 13:07:21 +08:00
Tienson Qin
1c88d7cb00
fix: can't convert ref-type to non-ref (checkbox)
2024-05-18 06:39:47 +08:00
Gabriel Horner
efab7f403e
chore: Remove unnecessary catch and rethrow for notification
...
Just encode notification in original exception to make conversion
as reusable as possible. Also make properties readable with :original-name
as they are case sensitive
2024-05-17 17:25:53 -04:00
Gabriel Horner
a17ed389e8
fix: can't delete a closed value being used
...
fixes LOG-3102
2024-05-17 15:37:52 -04:00
Gabriel Horner
4907f0eb74
fix: task related commands e.g. /Doing
...
Was broken by adding property ref value support to batch-set-property
2024-05-17 12:40:09 -04:00
Gabriel Horner
05b96d53fa
fix: display notification when trying to delete built-in choice
2024-05-17 11:07:53 -04:00
Tienson Qin
a50177096e
chore: remove debug
2024-05-17 21:00:57 +08:00
charlie
3e37fb6b4a
fix: typo
2024-05-17 11:25:10 +08:00
Gabriel Horner
3fdaf0474f
fix: can't add a class schema or page property
...
Removed related unused upsert property code. This became unused with #11311 .
Also fixed new page property not moving focus to property value
2024-05-16 17:47:49 -04:00
Gabriel Horner
8921767b69
fix: batch-set-property working with property value refs
...
Fixed batch-setting background-color. With this fix was then able
to migrate order-list-type to use :default. Also cleaned up
outdated assumptions in batch fn
2024-05-15 17:37:57 -04:00
Gabriel Horner
e50d3eff21
fix: setting block properties with raw value
...
With this fix able to convert 2 built-ins to :default. Also cleaned
up set-block-property! which had outdated assumptions
2024-05-15 16:10:02 -04:00
Tienson Qin
244de2187e
fix: quit batch tx mode even with errors
...
Also, throw errors and send notifications for apply-outliner-ops
2024-05-15 22:19:06 +08:00
Tienson Qin
a689266931
fix: don't persist :block.temp/fully-loaded?
2024-05-15 20:41:17 +08:00
Gabriel Horner
c554627041
fix: outliner lints
...
While fixing large vars, fixed needless circular dependency between
create-property-text-block and set-block-property
2024-05-14 15:11:29 -04:00
Gabriel Horner
4a7dab2763
fix: can't add or update closed values
2024-05-14 09:29:00 -04:00
Gabriel Horner
45bb11d28d
fix: db tests and :op typo
2024-05-13 17:05:32 -04:00
Tienson Qin
ce4cad2cc7
Refactor/move property handler to outliner dep ( #11311 )
...
The end goal is to get rid of `db/transact!` and send outliner ops to
the db worker.
Currently, some property ops are async, set-block-property! will also
need to be async because when setting a non-ref value (e.g. a number
str "2"), we need to query whether a block with the value exists, this
unfortunately, will be an async query, so we're risking turning more
functions to async in the future which makes it hard to reason about
the implementation.
2024-05-13 18:16:21 +08:00
Tienson Qin
bccf999853
fix: tests
2024-05-09 08:51:49 +08:00
Tienson Qin
bb5a3364e6
fix: outdent property child block replaces its parent
...
Fixes LOG-3141
2024-05-09 04:36:14 +08:00
Tienson Qin
d6ffd16799
fix: can't move blocks up
...
Fixes LOG-3140
2024-05-09 04:36:14 +08:00
Tienson Qin
89afdcdd7b
fix: outliner core tests
2024-05-08 01:29:23 +08:00
Gabriel Horner
ead9f30f1b
fix: typing hashtag sets heading
...
also remove unused var
2024-05-07 10:53:32 -04:00
Gabriel Horner
8a8dba6af8
fix: db graphs shouldn't have :block/marker at all
...
part of LOG-3042
2024-05-06 11:40:54 -04:00
Gabriel Horner
110813accd
fix: deps and frontend lints
2024-05-06 10:45:40 -04:00
Gabriel Horner
fe27ce9807
fix: remove handling file-graph specific marker
2024-05-06 09:39:02 -04:00