Commit Graph

4715 Commits

Author SHA1 Message Date
Tienson Qin
534c63a7b0 fix: p/then's argument needs to be a fn
close #4648
2022-03-20 21:09:01 +08:00
Tienson Qin
d58cfa04c1 Merge pull request #4450 from logseq/remove-refresh-button-on-mobile
remove refresh button / updated notifications on mobile
2022-03-20 19:06:51 +08:00
Junyi Du
9e150961d7 fix: persist other window's db on opening new window in another graph 2022-03-20 19:02:51 +08:00
Junyi Du
49f96cd71e dev: distinguishing () and 2022-03-20 19:02:51 +08:00
Junyi Du
2b9c995d69 fix: only unregister main window on quitting to ensure fs watching integrity 2022-03-20 19:02:51 +08:00
Junyi Du
4f533fd5a8 fix: load transit file on graph switching 2022-03-20 19:02:51 +08:00
Junyi Du
7bdbe82920 enhance: ask other windows to persist db 2022-03-20 19:02:51 +08:00
Junyi Du
8ef7c56e96 fix: leaked electron quit listener for fs watcher; sending fs event to multiple windows 2022-03-20 19:02:51 +08:00
Junyi Du
c52e913e22 fix: only persist current graph instead of all graphs 2022-03-20 19:02:51 +08:00
Junyi Du
7bc731fcee ui: opening new window i18n support 2022-03-20 19:02:51 +08:00
Junyi Du
d425a60038 fix: persisting db before opening new window 2022-03-20 19:02:51 +08:00
Junyi Du
59457f9b7d chore: rephrase search result wrong uuid prompting 2022-03-20 19:02:51 +08:00
Junyi Du
f24a509669 chore: diplaying message when cache is outdated; remove buggy unused uuid query 2022-03-20 19:02:51 +08:00
Gabriel Horner
9d38616215 Fix custom-query component not catching error
ui/catch-error needs to be in the render section of a component and the
previous catch was wrapped around the let. Also changed one other
warning which should be an error
2022-03-20 19:02:03 +08:00
Gabriel Horner
0414b5cdd1 Fail gracefully when weird state breaks references - see #4576
Also introduce component-error as its needs may diverge from block-error
2022-03-20 19:02:03 +08:00
Andelf
e19f574f4f chore: bump version 0.6.4 2022-03-19 19:14:02 +08:00
Gabriel Horner
6afb0fcdf2 Fix sentry platform not showing up on issues (#4631)
* Fix sentry platform not showing up as tag

Also added mobile to platform and added publishing as another tag
to allow for more search indices

* Address feedback - mobile platform should be native
2022-03-19 10:53:49 +08:00
Andelf
ec2b67f213 Merge branch 'master' into remove-refresh-button-on-mobile 2022-03-19 10:40:45 +08:00
Gabriel Horner
862350ee0e Fix bug where advanced query failed with rules arg and a found rule 2022-03-18 11:03:26 -04:00
llcc
9669e43722 enhance: separate desktop and mobile in Sentry for better issue management (#4621)
Co-authored-by: Andelf <andelf@gmail.com>
2022-03-18 18:00:45 +08:00
sawhney17
f6ab6aef3c Update dicts.cljs 2022-03-18 17:57:55 +08:00
Tienson Qin
8454ec1ee5 fix: sentry
close #4613
2022-03-18 16:44:03 +08:00
llcc
61bff0ae93 remove some unnecessary iCloud sync functions. 2022-03-18 13:43:40 +08:00
llcc
71cba1d314 Merge branch 'master' into remove-refresh-button-on-mobile 2022-03-18 12:51:08 +08:00
Yue Yang
e16297132f fix: use the correct variable in (seq coll)
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
2022-03-17 18:31:32 +08:00
Peng Xiao
4ea3d6eef8 fix: replace-block-reference-with-content-at-point not working 2022-03-17 16:16:24 +08:00
Gabriel Horner
6b935a8d58 Fix page-ref rule which was not bindable and failed fast
- page-ref had a :block/name embedded lookup ref which failed fast.
  datomic advises against this -
  https://docs.datomic.com/on-prem/schema/identity.html#:~:text=You%20cannot%20use%20them%20in%20the%20body%20of%20a%20query%2C%20use%20datalog%20clauses%20instead
- page-ref can handle binding args like last commit for page
- page-ref not failing fast on non-existing pages means that user can get meaningful results
  in more complex queries as seen in test
- Also remove try/catch as there should be no more queries that
  unintentionally cause the 'Nothing found for entity' error
- Also fixed lookup ref in srs cards which can be seen in stacktrace of
  #4576
2022-03-17 16:15:04 +08:00
Gabriel Horner
3282d1c766 Fix page rule unable to bind to args
Issue reported at
https://github.com/logseq/logseq/pull/4518#issuecomment-1068743086.
Also removed double reporting of errors in ui/catch-error to reduce
error noise for those scenarios
2022-03-17 16:15:04 +08:00
Tienson Qin
0f7caff45c Update thanks to Gabriel's suggestions 2022-03-17 16:09:29 +08:00
Tienson Qin
7bbe68fb36 fix: lint warnings 2022-03-17 16:09:29 +08:00
Tienson Qin
fc644e207b Adds :outliner/block-title-collapse-enabled? configuration option 2022-03-17 16:09:29 +08:00
Tienson Qin
96b1c6788b fix: restore collapse behaviour
related to #4583
2022-03-17 16:09:29 +08:00
Gabriel Horner
590ed9c302 Merge pull request #4589 from g1eny0ung/fix/4588
fix: cycle marker will remove `#` unexpectedly
2022-03-16 11:02:38 -04:00
llcc
1361728457 fix #+keyword issues in orgmode (#4573)
* fix(orgmode): don't parse some in-file #+keyword as page properties

e.g. #+Name:, #+tblfm:, etc.

* enhance(orgmode): display image and table's caption keyword

https://orgmode.org/manual/Captions.html

* enhance(orgmode): ignore some #+keywords for parsing properties.

Orgmode uses lots of file level #+keyword: styled keywords[1].
Logseq parses their value as page references except `title` and
`filters`, which pollutes Logseq database.

Users can setup `:ignored-page-property-tags` in config.edn to
make Logseq not parsing those keywords.

[1]: https://orgmode.org/manual/In_002dbuffer-Settings.html.

* use take-while instead. Thanks tienson.

* comment out new settings

* revert some merge conflicts.
2022-03-16 17:10:49 +08:00
Gabriel Horner
96da98e5bd Fix Tienson's nested not case 2022-03-16 16:04:59 +08:00
Gabriel Horner
a41dd0abfc Remove parse catch for consistent error handling
For advanced queries we error when invalid queries are written. We
should do the same for simple query.
Also add a test for tag query format
2022-03-16 16:04:59 +08:00
Gabriel Horner
e615423e6a Fix full text search without quotes not working
Decoupled query-dsl from search/block-search. This coupling added
unnecessary complexity as srs, custom queries and the api all depend
on query-dsl and don't need to be coupled to search/block-search
2022-03-16 16:04:59 +08:00
Gabriel Horner
6ca34f1430 Fix duplicate rules showing up in advanced query
Reported at
https://github.com/logseq/logseq/pull/4518#issuecomment-1064750042
2022-03-16 16:04:59 +08:00
Gabriel Horner
8468602881 query-dsl + tests cleanup
Remove old string checks that no longer apply. Also added another blank
string case that causes an issue
2022-03-16 16:04:59 +08:00
Gabriel Horner
5f0efcf2d8 Fix another nested boolean case
Also removed or nested complexity from
903a757ce2 that no longer seems necessary
2022-03-16 16:04:59 +08:00
Gabriel Horner
3a19687988 Fix nested boolean case - close #4510 2022-03-16 16:04:59 +08:00
Tienson Qin
e959e257b7 fix: db transactions expected sequential collection while #{} is not 2022-03-16 14:52:32 +08:00
Yue Yang
c58aa28f0b fix: ci
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
2022-03-16 01:33:32 +08:00
Yue Yang
08f96de72f fix: * to +
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
2022-03-16 00:57:21 +08:00
Yue Yang
88228129f7 fix: cycle marker will remove # unexpectedly
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
2022-03-16 00:51:18 +08:00
Tienson Qin
8cb6d26465 fix: preview card
close #4542
2022-03-15 15:30:16 +08:00
Gabriel Horner
8d40c4667b Node test runner improvements
- Print stacktrace when exception occurs!
- No longer depend on old test runner
- AND multiple test selections
- Add -v for compatibility with old test runner
2022-03-15 12:30:41 +08:00
Tienson Qin
130728adcd fix: lint warnings 2022-03-15 11:41:44 +08:00
Tienson Qin
cdb28cc1c2 Simplify movable? 2022-03-15 11:41:44 +08:00
Andelf
cadb98b689 refactor(dnd): refine check condition 2022-03-15 11:41:44 +08:00