From 3fd8f2be5038091824be63ab8a4f0859c14e72cf Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Tue, 20 Jan 2026 13:18:22 +0530
Subject: [PATCH] fix: test improvement

---
 .github/workflows/bats-test.yml       | 10 ++++++++++
 docker-compose/1_Auto_Upstall/noco.sh | 15 ++++++++++++---
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/bats-test.yml b/.github/workflows/bats-test.yml
index f1186b3f27..e7384a8d99 100644
--- a/.github/workflows/bats-test.yml
+++ b/.github/workflows/bats-test.yml
@@ -43,6 +43,16 @@ jobs:
           WORKING_DIR="$(pwd)/docker-compose/1_Auto_Upstall/tests"
           echo "WORKING_DIR=$WORKING_DIR" >> $GITHUB_ENV
 
+      - name: Pre-pull Docker images
+        run: |
+          docker pull nocodb/nocodb:latest &
+          docker pull postgres:16.6 &
+          docker pull redis:latest &
+          docker pull minio/minio:latest &
+          docker pull traefik:v3.1 &
+          docker pull nickfedor/watchtower &
+          wait
+
       - name: Run BATS test
         run: bats ${{ matrix.test }}
         env:
diff --git a/docker-compose/1_Auto_Upstall/noco.sh b/docker-compose/1_Auto_Upstall/noco.sh
index 76cd9d8baa..df5f86d4e1 100755
--- a/docker-compose/1_Auto_Upstall/noco.sh
+++ b/docker-compose/1_Auto_Upstall/noco.sh
@@ -1109,7 +1109,10 @@ EOF
 create_update_script() {
 	cat >./update.sh <<EOF
 #!/bin/bash
-$CONFIG_DOCKER_COMMAND compose pull
+if ! timeout 300 $CONFIG_DOCKER_COMMAND compose pull; then
+	echo "Failed to pull Docker images. Please check your network connection and try again."
+	exit 1
+fi
 $CONFIG_DOCKER_COMMAND compose up -d --force-recreate
 $CONFIG_DOCKER_COMMAND image prune -a -f
 EOF
@@ -1118,7 +1121,10 @@ EOF
 }
 
 start_services() {
-	$CONFIG_DOCKER_COMMAND compose pull
+	if ! timeout 300 $CONFIG_DOCKER_COMMAND compose pull; then
+		print_error "Failed to pull Docker images. Please check your network connection and try again."
+		exit 1
+	fi
 	$CONFIG_DOCKER_COMMAND compose up -d
 	print_empty_line
 	print_empty_line
@@ -1281,7 +1287,10 @@ restart_service() {
 
 upgrade_service() {
 	echo -e "\nUpgrading nocodb..."
-	$CONFIG_DOCKER_COMMAND compose pull
+	if ! timeout 300 $CONFIG_DOCKER_COMMAND compose pull; then
+		print_error "Failed to pull Docker images. Please check your network connection and try again."
+		return 1
+	fi
 	$CONFIG_DOCKER_COMMAND compose up -d --force-recreate
 	$CONFIG_DOCKER_COMMAND image prune -a -f
 }