clone/nocodb
1
0
Fork 0
mirror of https://github.com/nocodb/nocodb.git synced 2026-05-02 18:07:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move readonly props from meta to new cols for better stability

Browse Source
This commit is contained in:
Pranav C
2024-06-18 19:06:18 +00:00
parent 3820e91a1b
commit 4561423226
17 changed files with 87 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue
View File

@@ -56,9 +56,8 @@ const formState = ref<ProjectCreateForm>({
},
sslUse: SSLUsage.No,
extraParameters: [],
meta: {
[SourceRestriction.META_READONLY]: true,
[SourceRestriction.DATA_READONLY]: false,
'is_schema_readonly': true,
'is_data_readonly': false,
},
})
@@ -249,7 +248,8 @@ const createSource = async () => {
config,
inflection_column: formState.value.inflection.inflectionColumn,
inflection_table: formState.value.inflection.inflectionTable,
meta: formState.value.meta,
is_schema_readonly: formState.value.is_schema_readonly,
is_data_readonly: formState.value.is_data_readonly,
})
$poller.subscribe(
@@ -401,18 +401,16 @@ const toggleModal = (val: boolean) => {
}
const allowMetaWrite = computed({
get: () => !formState.value.meta[SourceRestriction.META_READONLY],
get: () => !formState.value.is_schema_readonly,
set: (v) => {
formState.value.meta = formState.value.meta || {}
formState.value.meta[SourceRestriction.META_READONLY] = !v
formState.value.is_schema_readonly = !v
},
})
const allowDataWrite = computed({
get: () => !formState.value.meta[SourceRestriction.DATA_READONLY],
get: () => !formState.value.is_data_readonly,
set: (v) => {
formState.value.meta = formState.value.meta || {}
formState.value.meta[SourceRestriction.DATA_READONLY] = !v
formState.value.is_data_readonly = !v
},
})
</script>

28
packages/nc-gui/components/dashboard/settings/data-sources/EditBase.vue
View File

@@ -61,10 +61,8 @@ const formState = ref<ProjectCreateForm>({
},
sslUse: SSLUsage.No,
extraParameters: [],
meta: {
[SourceRestriction.META_READONLY]: true,
[SourceRestriction.DATA_READONLY]: false,
},
is_schema_readonly: true,
is_data_readonly: false,
})
const customFormState = ref<ProjectCreateForm>({
@@ -76,10 +74,8 @@ const customFormState = ref<ProjectCreateForm>({
},
sslUse: SSLUsage.No,
extraParameters: [],
meta: {
[SourceRestriction.META_READONLY]: true,
[SourceRestriction.DATA_READONLY]: false,
},
is_schema_readonly: true,
is_data_readonly: false,
})
const validators = computed(() => {
@@ -237,7 +233,8 @@ const editBase = async () => {
config,
inflection_column: formState.value.inflection.inflectionColumn,
inflection_table: formState.value.inflection.inflectionTable,
meta: formState.value.meta || {},
is_schema_readonly: formState.value.is_schema_readonly,
is_data_readonly: formState.value.is_data_readonly,
})
$e('a:source:edit:extdb')
@@ -349,7 +346,8 @@ onMounted(async () => {
},
extraParameters: tempParameters,
sslUse: SSLUsage.No,
meta: activeBase.meta || {},
is_schema_readonly: activeBase.is_schema_readonly,
is_data_readonly: activeBase.is_data_readonly,
}
updateSSLUse()
}
@@ -369,18 +367,16 @@ watch(
)
const allowMetaWrite = computed({
get: () => !formState.value.meta[SourceRestriction.META_READONLY],
get: () => !formState.value.is_schema_readonly,
set: (v) => {
formState.value.meta = formState.value.meta || {}
formState.value.meta[SourceRestriction.META_READONLY] = !v
formState.value.is_schema_readonly = !v
},
})
const allowDataWrite = computed({
get: () => !formState.value.meta[SourceRestriction.DATA_READONLY],
get: () => !formState.value.is_data_readonly,
set: (v) => {
formState.value.meta = formState.value.meta || {}
formState.value.meta[SourceRestriction.DATA_READONLY] = !v
formState.value.is_data_readonly = !v
},
})
</script>