From 58005b635ab4bc5024093eacb75545bda26eb4c1 Mon Sep 17 00:00:00 2001 From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com> Date: Tue, 13 Jan 2026 07:25:14 +0000 Subject: [PATCH] chore(nc-gui): lint --- .../nc/form-builder/input/WorkflowInput.vue | 2 ++ .../column/LinkedToAnotherRecordOptions.vue | 24 +++++++++---------- .../smartsheet/column/LookupOptions.vue | 2 +- .../smartsheet/column/RollupOptions.vue | 2 +- .../components/smartsheet/details/Fields.vue | 4 ++-- .../grid/canvas/composables/useCopyPaste.ts | 4 ++-- .../smartsheet/header/AddLookupsOrRollups.vue | 2 +- .../smartsheet/toolbar/AddLookupsDropdown.vue | 2 +- .../nc-gui/components/tabs/Smartsheet.vue | 11 +++++---- .../nc-gui/composables/useGridViewData.ts | 10 ++++---- .../components/filter/filter-group/index.vue | 1 - 11 files changed, 32 insertions(+), 32 deletions(-) diff --git a/packages/nc-gui/components/nc/form-builder/input/WorkflowInput.vue b/packages/nc-gui/components/nc/form-builder/input/WorkflowInput.vue index e13d46935c..d6c259bb0c 100644 --- a/packages/nc-gui/components/nc/form-builder/input/WorkflowInput.vue +++ b/packages/nc-gui/components/nc/form-builder/input/WorkflowInput.vue @@ -175,6 +175,7 @@ onMounted(() => { let lastIndex = 0 let match + // eslint-disable-next-line no-cond-assign while ((match = expressionRegex.exec(vModel.value)) !== null) { const [fullMatch, expression] = match @@ -211,6 +212,7 @@ onMounted(() => { const pathRegex = /\.(\w+)|\[['"]([^'"]+)['"]\]/g let pathMatch + // eslint-disable-next-line no-cond-assign while ((pathMatch = pathRegex.exec(currentPath)) !== null) { // pathMatch[1] is dot notation capture, pathMatch[2] is bracket notation capture properties.push(pathMatch[1] || pathMatch[2]) diff --git a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue index dec017b50a..d967003e08 100644 --- a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue +++ b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue @@ -56,7 +56,7 @@ const { t } = useI18n() const { getPlanTitle } = useEeConfig() -const { metas, getMeta, getMetaByKey } = useMetas() +const { getMeta, getMetaByKey } = useMetas() if (!isEdit.value) { setAdditionalValidations({ @@ -123,6 +123,17 @@ const { baseTables } = storeToRefs(tablesStore) const { isFeatureEnabled } = useBetaFeatureToggle() +// Check if linked view is private (views inherit from table) +const isLinkedViewPrivate = computed(() => { + if (!vModel.value.childViewId) return false + const childId = vModel.value?.is_custom_link ? vModel.value?.custom?.ref_model_id : vModel.value?.childId + if (!childId) return false + const baseId = meta.value?.base_id + const tableMeta = getMetaByKey(baseId, childId) + // Check is_private flag from API response + return !!(tableMeta && (tableMeta as any).is_private) +}) + const refTables = computed(() => { if (isEdit.value) { // eslint-disable-next-line @typescript-eslint/no-use-before-define @@ -313,17 +324,6 @@ const isLinkedTablePrivate = computed(() => { return !!(tableMeta && (tableMeta as any).is_private) }) -// Check if linked view is private (views inherit from table) -const isLinkedViewPrivate = computed(() => { - if (!vModel.value.childViewId) return false - const childId = vModel.value?.is_custom_link ? vModel.value?.custom?.ref_model_id : vModel.value?.childId - if (!childId) return false - const baseId = meta.value?.base_id - const tableMeta = getMetaByKey(baseId, childId) - // Check is_private flag from API response - return !!(tableMeta && (tableMeta as any).is_private) -}) - const linkType = computed({ get: () => (isEdit.value ? vModel.value?.colOptions?.type : vModel.value?.type) ?? null, set: (value) => { diff --git a/packages/nc-gui/components/smartsheet/column/LookupOptions.vue b/packages/nc-gui/components/smartsheet/column/LookupOptions.vue index 218e867880..49eaedead6 100644 --- a/packages/nc-gui/components/smartsheet/column/LookupOptions.vue +++ b/packages/nc-gui/components/smartsheet/column/LookupOptions.vue @@ -34,7 +34,7 @@ const baseStore = useBase() const { tables } = storeToRefs(baseStore) -const { metas, getMeta, getMetaByKey } = useMetas() +const { getMeta, getMetaByKey } = useMetas() const filterRef = ref() diff --git a/packages/nc-gui/components/smartsheet/column/RollupOptions.vue b/packages/nc-gui/components/smartsheet/column/RollupOptions.vue index 835e3cf82a..70fc4924d9 100644 --- a/packages/nc-gui/components/smartsheet/column/RollupOptions.vue +++ b/packages/nc-gui/components/smartsheet/column/RollupOptions.vue @@ -34,7 +34,7 @@ const baseStore = useBase() const { tables } = storeToRefs(baseStore) -const { metas, getMeta, getMetaByKey } = useMetas() +const { getMeta, getMetaByKey } = useMetas() const { t } = useI18n() diff --git a/packages/nc-gui/components/smartsheet/details/Fields.vue b/packages/nc-gui/components/smartsheet/details/Fields.vue index 1bca1af15e..ae4979eecd 100644 --- a/packages/nc-gui/components/smartsheet/details/Fields.vue +++ b/packages/nc-gui/components/smartsheet/details/Fields.vue @@ -971,7 +971,7 @@ const saveChanges = async () => { const res = await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: columnsHash.value, ops: ops.value, @@ -1018,7 +1018,7 @@ const saveChanges = async () => { columnsHash.value = ( await $api.internal.getOperation(meta.value!.fk_workspace_id!, meta.value!.base_id!, { operation: 'columnsHash', - tableId: meta.value?.id!, + tableId: meta.value?.id as string, }) ).hash diff --git a/packages/nc-gui/components/smartsheet/grid/canvas/composables/useCopyPaste.ts b/packages/nc-gui/components/smartsheet/grid/canvas/composables/useCopyPaste.ts index e47577ac5c..99a4544e39 100644 --- a/packages/nc-gui/components/smartsheet/grid/canvas/composables/useCopyPaste.ts +++ b/packages/nc-gui/components/smartsheet/grid/canvas/composables/useCopyPaste.ts @@ -316,7 +316,7 @@ export function useCopyPaste({ const columnsHash = ( await $api.internal.getOperation(meta.value!.fk_workspace_id!, meta.value!.base_id!, { operation: 'columnsHash', - tableId: meta.value?.id!, + tableId: meta.value?.id as string, }) ).hash const columnsLength = meta.value?.columns?.length || 0 @@ -351,7 +351,7 @@ export function useCopyPaste({ await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: columnsHash, ops: bulkOpsCols, diff --git a/packages/nc-gui/components/smartsheet/header/AddLookupsOrRollups.vue b/packages/nc-gui/components/smartsheet/header/AddLookupsOrRollups.vue index a2784f6c99..0dc3d99253 100644 --- a/packages/nc-gui/components/smartsheet/header/AddLookupsOrRollups.vue +++ b/packages/nc-gui/components/smartsheet/header/AddLookupsOrRollups.vue @@ -159,7 +159,7 @@ const createLookupsOrRollup = async () => { await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: meta.value?.columnsHash, ops: bulkOpsCols, diff --git a/packages/nc-gui/components/smartsheet/toolbar/AddLookupsDropdown.vue b/packages/nc-gui/components/smartsheet/toolbar/AddLookupsDropdown.vue index 367d8d0584..0004618fd6 100644 --- a/packages/nc-gui/components/smartsheet/toolbar/AddLookupsDropdown.vue +++ b/packages/nc-gui/components/smartsheet/toolbar/AddLookupsDropdown.vue @@ -105,7 +105,7 @@ const createLookups = async () => { await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: meta.value?.columnsHash, ops: bulkOpsCols, diff --git a/packages/nc-gui/components/tabs/Smartsheet.vue b/packages/nc-gui/components/tabs/Smartsheet.vue index 099dfb950d..fc0c84dda7 100644 --- a/packages/nc-gui/components/tabs/Smartsheet.vue +++ b/packages/nc-gui/components/tabs/Smartsheet.vue @@ -22,11 +22,6 @@ const { ncNavigateTo } = useGlobal() const route = useRoute() -const meta = computed(() => { - const viewId = route.params.viewId as string - return viewId && getMetaByKey(activeProjectId.value, viewId) -}) - const { handleSidebarOpenOnMobileForNonViews } = useConfigStore() const { activeTableId } = storeToRefs(useTablesStore()) @@ -37,6 +32,12 @@ const { activeWorkspaceId } = storeToRefs(useWorkspace()) const viewStore = useViewsStore() const { activeView, openedViewsTab, activeViewTitleOrId, isViewsLoading } = storeToRefs(viewStore) + +const meta = computed(() => { + const viewId = route.params.viewId as string + return viewId && getMetaByKey(activeProjectId.value, viewId) +}) + const { isGallery, isGrid, isForm, isKanban, isLocked, isMap, isCalendar, xWhere, eventBus } = useProvideSmartsheetStore( activeView, meta, diff --git a/packages/nc-gui/composables/useGridViewData.ts b/packages/nc-gui/composables/useGridViewData.ts index 8503bdf6db..ebeb718077 100644 --- a/packages/nc-gui/composables/useGridViewData.ts +++ b/packages/nc-gui/composables/useGridViewData.ts @@ -41,8 +41,6 @@ export function useGridViewData( const { $api } = useNuxtApp() - const { appInfo } = useGlobal() - const isBulkOperationInProgress = ref(false) const { @@ -700,14 +698,14 @@ export function useGridViewData( const columnsHash = ( await $api.internal.getOperation(meta.value!.fk_workspace_id!, meta.value!.base_id!, { operation: 'columnsHash', - tableId: meta.value?.id!, + tableId: meta.value?.id as string, }) ).hash await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: columnsHash, ops: newCols.map((col: ColumnType) => ({ @@ -740,14 +738,14 @@ export function useGridViewData( const columnsHash = ( await $api.internal.getOperation(meta.value!.fk_workspace_id!, meta.value!.base_id!, { operation: 'columnsHash', - tableId: meta.value?.id!, + tableId: meta.value?.id as string, }) ).hash await $api.internal.postOperation( meta.value!.fk_workspace_id!, meta.value!.base_id!, - { operation: 'columnsBulk', tableId: meta.value?.id! }, + { operation: 'columnsBulk', tableId: meta.value?.id as string }, { hash: columnsHash, ops: newCols.map((col: ColumnType) => ({ diff --git a/packages/nc-gui/pages/playground/components/filter/filter-group/index.vue b/packages/nc-gui/pages/playground/components/filter/filter-group/index.vue index 96b8adb0d6..483c9111c9 100644 --- a/packages/nc-gui/pages/playground/components/filter/filter-group/index.vue +++ b/packages/nc-gui/pages/playground/components/filter/filter-group/index.vue @@ -2,7 +2,6 @@ import { mockSetupInit } from '../../../-helper/mock-setup' import MockInjection from '../../MockInjection.vue' const { metas } = useMetas() -const defaultTableId = 'mtWA9ZXvsuh' const rootMeta = ref({}) const columns = computedAsync(async () => {