refactor: review comments

This commit is contained in:
Pranav C
2024-10-06 07:21:35 +00:00
parent 36dd6bd23b
commit 9782048b99
2 changed files with 12 additions and 2 deletions

View File

@@ -12,9 +12,19 @@ const logger = {
}; };
const decryptConfig = async (encryptedConfig: string, secret: string) => { const decryptConfig = async (encryptedConfig: string, secret: string) => {
return CryptoJS.AES.decrypt(encryptedConfig, secret).toString( if (!encryptedConfig) return encryptedConfig;
const decryptedVal = CryptoJS.AES.decrypt(encryptedConfig, secret).toString(
CryptoJS.enc.Utf8, CryptoJS.enc.Utf8,
); );
// validate by parsing JSON
try {
JSON.parse(decryptedVal);
} catch {
throw new Error('Config decryption failed');
}
return decryptedVal;
}; };
// decrypt datasource details in source table and integration table // decrypt datasource details in source table and integration table

View File

@@ -1,7 +1,7 @@
const fs = require('fs') const fs = require('fs')
const path = require('path') const path = require('path')
const packageJsonPath =path.join(__dirname, '..', 'packages', 'nc-secret-cli', 'package.json') const packageJsonPath = path.join(__dirname, '..', 'packages', 'nc-secret-cli', 'package.json')
const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8')) const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'))