clone/nocodb
1
0
Fork 0
mirror of https://github.com/nocodb/nocodb.git synced 2026-04-25 07:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: l.shouldKeepModalOpen is not a function

Browse Source
This commit is contained in:
Ramesh Mane
2026-01-17 10:29:19 +00:00
parent d78fbfb970
commit b5189538a0
7 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nc-gui/components/smartsheet/Form.vue
View File

@@ -227,7 +227,7 @@ const editOrAddProviderRef = ref()
const onVisibilityChange = (state: 'showAddColumn' | 'showEditColumn') => {
dropdownStates.value[state] = true
if (editOrAddProviderRef.value && !editOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (editOrAddProviderRef.value && !editOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
dropdownStates.value[state] = false
}
}

2
packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
View File

@@ -1501,7 +1501,7 @@ const saveOrUpdateRecords = async (
const editOrAddProviderRef = ref()
const onVisibilityChange = () => {
addColumnDropdown.value = editOrAddProviderRef.value?.shouldKeepModalOpen()
addColumnDropdown.value = editOrAddProviderRef.value?.shouldKeepModalOpen?.()
}
const COL_VIRTUAL_MARGIN = 5

2
packages/nc-gui/components/smartsheet/grid/Table.vue
View File

@@ -1297,7 +1297,7 @@ const editOrAddProviderRef = ref()
const onVisibilityChange = () => {
addColumnDropdown.value = true
if (!editOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (!editOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
addColumnDropdown.value = false
persistMenu.value = altModifier.value
}

6
packages/nc-gui/components/smartsheet/grid/canvas/index.vue
View File

@@ -430,7 +430,7 @@ const isDropdownVisible = computed({
set(value) {
// block closing editOrAddMenu if it needs to be keep open
// for example while saving/updating column it needs to be in open state to avoid partial save
if (!value && _isCreateOrEditColumnDropdownOpen.value && columnEditOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (!value && _isCreateOrEditColumnDropdownOpen.value && columnEditOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
return
}
_isDropdownVisible.value = value
@@ -444,7 +444,7 @@ const isCreateOrEditColumnDropdownOpen = computed({
set(value) {
// block closing editOrAddMenu if it needs to be keep open
// for example while saving/updating column it needs to be in open state to avoid partial save
if (!value && columnEditOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (!value && columnEditOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
return
}
_isCreateOrEditColumnDropdownOpen.value = value
@@ -748,7 +748,7 @@ const onVisibilityChange = (value: boolean) => {
if (value) {
isDropdownVisible.value = true
} else if (isCreateOrEditColumnDropdownOpen.value) {
const keepOpen = columnEditOrAddProviderRef.value?.shouldKeepModalOpen()
const keepOpen = columnEditOrAddProviderRef.value?.shouldKeepModalOpen?.()
isDropdownVisible.value = keepOpen
isCreateOrEditColumnDropdownOpen.value = keepOpen
if (!keepOpen) {

2
packages/nc-gui/components/smartsheet/header/Cell.vue
View File

@@ -134,7 +134,7 @@ const openDropDown = (e: Event) => {
const onVisibleChange = () => {
editColumnDropdown.value = true
if (!editOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (!editOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
editColumnDropdown.value = false
enableDescription.value = false
}

2
packages/nc-gui/components/smartsheet/header/VirtualCell.vue
View File

@@ -207,7 +207,7 @@ const openDropDown = (e: Event) => {
const onVisibleChange = () => {
editColumnDropdown.value = true
if (!editOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (!editOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
editColumnDropdown.value = false
enableDescription.value = false
}

2
packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
View File

@@ -525,7 +525,7 @@ const onFieldsMenuDropdownVisibilityChange = (value: boolean) => {
const onAddColumnDropdownVisibilityChange = () => {
addColumnDropdown.value = true
if (editOrAddProviderRef.value && !editOrAddProviderRef.value?.shouldKeepModalOpen()) {
if (editOrAddProviderRef.value && !editOrAddProviderRef.value?.shouldKeepModalOpen?.()) {
addColumnDropdown.value = false
}
}