Commit Graph

162 Commits

Author SHA1 Message Date
Wing-Kam Wong
6a98ea8e3b chore(nc-gui): lint 2023-01-12 16:20:10 +08:00
Raju Udava
a6dd286484 Merge pull request #4762 from nocodb/fix/miscellaneous-bugs
Fix - Miscellaneous bugs
2023-01-11 21:06:10 +05:30
Pranav C
c3503bc82b fix(gui): handle empty string in percent and currency cell as null
Signed-off-by: Pranav C <pranavxc@gmail.com>
2023-01-11 16:07:31 +05:30
Wing-Kam Wong
183a123cae fix(nc-gui): multi select behaviours based on roles 2023-01-11 18:16:43 +08:00
Wing-Kam Wong
2c6521c7e4 fix(nc-gui): single select behaviours based on roles 2023-01-11 18:16:32 +08:00
Pranav C
25129c23fb fix(gui): stop mouse event propagation from json cell to avoid unexpected behaviour
re #4760

Signed-off-by: Pranav C <pranavxc@gmail.com>
2023-01-05 17:52:41 +05:30
Pranav C
27d05c65bb fix(gui): assign click event handler to button
re #4760

Signed-off-by: Pranav C <pranavxc@gmail.com>
2023-01-05 15:30:49 +05:30
Pranav C
d395d643bb fix(gui): treat empty string as null for number fields
re #4701

Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-12-29 13:09:49 +05:30
Wing-Kam Wong
87964a1643 chore: merge with develop 2022-12-05 14:03:49 +08:00
Wing-Kam Wong
5291dc6c20 fix(nc-gui): use YYYY-MM-DD HH:mm:ss instead 2022-12-05 13:23:13 +08:00
mertmit
91968ba6be fix: PR requested changes
Signed-off-by: mertmit <mertmit99@gmail.com>
2022-12-03 11:21:59 +03:00
mertmit
5c433e3086 feat: team & settings modal data sources tab revised
Signed-off-by: mertmit <mertmit99@gmail.com>
2022-12-03 11:21:59 +03:00
Wing-Kam Wong
55fd0fee74 feat(nc-gui): format DateTime data 2022-12-03 14:22:09 +08:00
Wing-Kam Wong
424d23f2cb chore(nc-gui): resolve PR comments 2022-12-03 13:45:44 +08:00
Wing-Kam Wong
b1b362366e fix(nc-gui): type issues 2022-12-02 14:55:02 +08:00
Pranav C
4283f48ee8 fix(gui): add validation for paste data
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-12-01 11:08:10 +05:30
Pranav C
916029c007 fix(gui): avoiding blocking click event propagation
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-12-01 11:08:10 +05:30
Pranav C
5c36a3e9d6 chore(gui): lint
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-12-01 11:08:08 +05:30
Pranav C
0d13701bfe fix: avoid opening dropdown on cmd/alt/shift/ctrl key press
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-12-01 10:59:41 +05:30
Wing-Kam Wong
289f8de9e5 Merge branch 'develop' into feat/keyboard-manoeuvre 2022-11-30 20:02:27 +08:00
Pranav C
a8f421f22b fix(gui): allow drag select, mouse select and cmd/ctrl + a select
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-30 15:13:32 +05:30
Wing-Kam Wong
dae1c53a91 feat(nc-gui): skip keydown logic if drawer / modal is active 2022-11-29 13:57:39 +08:00
Wing-Kam Wong
507a1f496a feat(nc-gui): keyboard maneuver for json cell 2022-11-28 19:40:26 +08:00
Wing-Kam Wong
70ea1fda32 fix(nc-gui): lint 2022-11-28 19:01:01 +08:00
Wing-Kam Wong
2af5e7d224 fix(nc-gui): resolve PR comments 2022-11-28 17:37:09 +08:00
Wing-Kam Wong
cd56d6bf1e feat(nc-gui): click enter to open modal, click enter again to attach file 2022-11-28 16:28:26 +08:00
Wing-Kam Wong
af685a9cf8 feat(nc-gui): add active class when the modal is open 2022-11-28 16:28:03 +08:00
Wing-Kam Wong
2f5160e047 feat(nc-gui): useSelectedCellKeyupListener logic on datetime picker 2022-11-28 14:34:35 +08:00
Wing-Kam Wong
ccf42266fe fix(nc-gui): query the active date picker only 2022-11-28 14:03:45 +08:00
Wing-Kam Wong
ae2271c7b8 feat(nc-gui): cmd + ; to select the current date(time) 2022-11-28 13:48:51 +08:00
Wing-Kam Wong
21c0be04a2 fix(nc-gui): return if expanded form is active for Enter & Escape on date picker 2022-11-28 13:27:35 +08:00
Wing-Kam Wong
d5097bbfca Merge branch 'develop' into feat/keyboard-manoeuvre 2022-11-28 11:22:03 +08:00
Wing-Kam Wong
5d048d37f2 fix(nc-gui): set show-search always true 2022-11-25 16:21:08 +08:00
Wing-Kam Wong
3b02b6627e feat(nc-gui): keyboard maneuver on date picker 2022-11-24 18:39:07 +08:00
Pranav C
12a95968ba fix(gui): check default value defined or not
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 16:08:39 +05:30
Pranav C
9b9894f72b fix(gui): remove unnecessary chars from column default value
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 15:23:47 +05:30
Pranav C
523105c8b0 fix(gui): allow typing directly in single select
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 13:33:26 +05:30
Pranav C
043cbcf4e7 fix(gui): block event bubbling
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 13:29:12 +05:30
Pranav C
913a3ba800 fix(gui): skip delete key and toggle options list only if char key pressed
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 13:22:43 +05:30
Pranav C
eb12c2f63c fix: allow arrow navigation with multi select
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 12:50:31 +05:30
Pranav C
0d98aac265 refactor: group import statements
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
26d7759c9e fix: clear icon in multi select
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
084b2c7a5e fix: clear icon in single select
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
064436d550 refactor(gui): reload table meta after adding new option
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
56dc7615c3 refactor(gui): requested changes
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
6ffd7b5e5d feat(gui): use title if id is missing
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
61661e4a9c fix(gui): hide add option from shared form view
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
7d5fb68d2e test(playwright): add method to verify selected options
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
b4b63e5140 test: add playwright test
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30
Pranav C
ac05d8fa6c feat(gui): show temporary value while syncing in background
Signed-off-by: Pranav C <pranavxc@gmail.com>
2022-11-22 11:49:06 +05:30