clone/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-05-01 02:06:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup event listeners with solid-primitives/event-listener (#20619)

Browse Source
This commit is contained in:
Brendan Allan
2026-04-02 17:40:03 +08:00
committed by GitHub
parent 327f62526a
commit 69d047ae7d
22 changed files with 102 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/ui/src/components/file.tsx
View File

@@ -16,6 +16,7 @@ import {
} from "@pierre/diffs"
import { type PreloadMultiFileDiffResult } from "@pierre/diffs/ssr"
import { createMediaQuery } from "@solid-primitives/media"
import { makeEventListener } from "@solid-primitives/event-listener"
import { ComponentProps, createEffect, createMemo, createSignal, onCleanup, onMount, Show, splitProps } from "solid-js"
import { createDefaultOptions, styleVariables } from "../pierre"
import { markCommentedDiffLines, markCommentedFileLines } from "../pierre/commented-lines"
@@ -286,17 +287,10 @@ function useFileViewer(config: ViewerConfig) {
createEffect(() => {
if (!config.enableLineSelection()) return
container.addEventListener("mousedown", handleMouseDown)
container.addEventListener("mousemove", handleMouseMove)
window.addEventListener("mouseup", handleMouseUp)
document.addEventListener("selectionchange", handleSelectionChange)
onCleanup(() => {
container.removeEventListener("mousedown", handleMouseDown)
container.removeEventListener("mousemove", handleMouseMove)
window.removeEventListener("mouseup", handleMouseUp)
document.removeEventListener("selectionchange", handleSelectionChange)
})
makeEventListener(container, "mousedown", handleMouseDown)
makeEventListener(container, "mousemove", handleMouseMove)
makeEventListener(window, "mouseup", handleMouseUp)
makeEventListener(document, "selectionchange", handleSelectionChange)
})
onCleanup(() => {