clone/vikunja
1
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-04-30 08:56:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: use openid provider name instead of generic "OIDC" in synced team names

Browse Source 
Teams synced from OpenID Connect providers were always named with "(OIDC)"
suffix (e.g., "DevTeam (OIDC)"). This changes it to use the configured
provider name instead (e.g., "DevTeam (Keycloak)"), making it easier to
identify which provider a team came from when multiple OIDC providers are
configured. Existing team names will be updated automatically on next user
login.

https://claude.ai/code/session_012LXXPvYe6i27WTcha1PL7A
This commit is contained in:
Claude
2026-03-24 12:17:35 +00:00
committed by kolaente
parent 74ecc6fffd
commit 121fd3c9f1
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/modules/auth/openid/openid_test.go
View File

@@ -124,14 +124,14 @@ func TestGetOrCreateUser(t *testing.T) {
},
}
provider := &Provider{}
provider := &Provider{Name: "Vikunja Login"}
idToken := &oidc.IDToken{Issuer: "https://some.service.com", Subject: "12345"}
u, err := getOrCreateUser(s, cl, provider, idToken)
require.NoError(t, err)
teamData := getTeamDataFromToken(cl.VikunjaGroups, nil)
require.NoError(t, err)
err = models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "OIDC")
err = models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", provider.Name)
require.NoError(t, err)
err = s.Commit()
require.NoError(t, err)
@@ -141,7 +141,7 @@ func TestGetOrCreateUser(t *testing.T) {
"email": cl.Email,
}, false)
db.AssertExists(t, "teams", map[string]interface{}{
"name": team + " (OIDC)",
"name": team + " (" + provider.Name + ")",
"external_id": oidcID,
"is_public": false,
}, false)
@@ -161,19 +161,19 @@ func TestGetOrCreateUser(t *testing.T) {
},
}
provider := &Provider{}
provider := &Provider{Name: "Vikunja Login"}
idToken := &oidc.IDToken{Issuer: "https://some.service.com", Subject: "12345"}
u, err := getOrCreateUser(s, cl, provider, idToken)
require.NoError(t, err)
teamData := getTeamDataFromToken(cl.VikunjaGroups, nil)
err = models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "OIDC")
err = models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", provider.Name)
require.NoError(t, err)
err = s.Commit()
require.NoError(t, err)
db.AssertExists(t, "teams", map[string]interface{}{
"name": team + " (OIDC)",
"name": team + " (" + provider.Name + ")",
"external_id": oidcID,
"is_public": true,
}, false)
@@ -195,7 +195,7 @@ func TestGetOrCreateUser(t *testing.T) {
u := &user.User{ID: 10}
teamData := getTeamDataFromToken(cl.VikunjaGroups, nil)
err := models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "OIDC")
err := models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "Vikunja Login")
require.NoError(t, err)
err = s.Commit()
require.NoError(t, err)
@@ -216,7 +216,7 @@ func TestGetOrCreateUser(t *testing.T) {
u := &user.User{ID: 10}
teamData := getTeamDataFromToken(cl.VikunjaGroups, nil)
err := models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "OIDC")
err := models.SyncExternalTeamsForUser(s, u, teamData, "https://some.issuer", "Vikunja Login")
require.NoError(t, err)
err = s.Commit()
require.NoError(t, err)