mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-05-19 10:23:00 +00:00
aa1956e1aa
Hardcoding the three exact strings localhost / 127.0.0.1 / ::1 rejected legitimate loopback redirects like 127.0.0.2:1234 (anywhere in 127.0.0.0/8) or [0:0:0:0:0:0:0:1]:1234 (expanded IPv6 loopback). Use net.IP.IsLoopback() to cover the full loopback ranges, and match "localhost" case-insensitively. 0.0.0.0 stays rejected as it is not a loopback address. https://claude.ai/code/session_01LsTDrCJ7trE6WQ4FYf78UB
54 lines
1.7 KiB
Go
54 lines
1.7 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package oauth2server
|
|
|
|
import (
|
|
"net"
|
|
"net/url"
|
|
"strings"
|
|
)
|
|
|
|
// ValidateRedirectURI checks that the redirect_uri is either a Vikunja native
|
|
// app scheme (e.g. vikunja-flutter://callback) or a loopback http URL as
|
|
// recommended by RFC 8252 for native apps that cannot register a custom
|
|
// scheme. Any address in 127.0.0.0/8, the IPv6 loopback (::1, in any
|
|
// notation), and the literal hostname "localhost" are accepted; dangerous
|
|
// schemes like javascript:, data:, https://, or non-loopback http:// targets
|
|
// are rejected.
|
|
func ValidateRedirectURI(redirectURI string) bool {
|
|
u, err := url.Parse(redirectURI)
|
|
if err != nil || u.Scheme == "" {
|
|
return false
|
|
}
|
|
|
|
if strings.HasPrefix(u.Scheme, "vikunja-") {
|
|
return true
|
|
}
|
|
|
|
if u.Scheme == "http" {
|
|
host := u.Hostname()
|
|
if strings.EqualFold(host, "localhost") {
|
|
return true
|
|
}
|
|
if ip := net.ParseIP(host); ip != nil && ip.IsLoopback() {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|