mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-04-24 22:25:15 +00:00
49bba7f830
Refactor functions that created their own sessions when called from within existing transactions, which caused "database table is locked" errors in SQLite's shared-cache mode. Changes: - Add files.CreateWithSession() to reuse caller's session - Refactor DeleteBackgroundFileIfExists() to accept session parameter - Add variadic session parameter to notifications.Notify() and Notifiable.ShouldNotify() interface - Update all Notify callers (~17 sites) to pass their session through - Use files.CreateWithSession in SaveBackgroundFile and NewAttachment - Fix test code to commit sessions before assertions
138 lines
3.5 KiB
Go
138 lines
3.5 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package notifications
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"xorm.io/xorm"
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
type testNotification struct {
|
|
Test string
|
|
OtherValue int64
|
|
}
|
|
|
|
// ToMail returns the mail notification for testNotification
|
|
func (n *testNotification) ToMail(_ string) *Mail {
|
|
return NewMail().
|
|
Subject("Test Notification").
|
|
Line(n.Test)
|
|
}
|
|
|
|
// ToDB returns the testNotification notification in a format which can be saved in the db
|
|
func (n *testNotification) ToDB() interface{} {
|
|
data := make(map[string]interface{}, 2)
|
|
data["test"] = n.Test
|
|
data["other_value"] = n.OtherValue
|
|
return data
|
|
}
|
|
|
|
// Name returns the name of the notification
|
|
func (n *testNotification) Name() string {
|
|
return "test.notification"
|
|
}
|
|
|
|
type testNotifiable struct {
|
|
ShouldSendNotification bool
|
|
Language string
|
|
}
|
|
|
|
// RouteForMail routes a test notification for mail
|
|
func (t *testNotifiable) RouteForMail() (string, error) {
|
|
return "some@email.com", nil
|
|
}
|
|
|
|
// RouteForDB routes a test notification for db
|
|
func (t *testNotifiable) RouteForDB() int64 {
|
|
return 42
|
|
}
|
|
|
|
func (t *testNotifiable) ShouldNotify(_ ...*xorm.Session) (should bool, err error) {
|
|
return t.ShouldSendNotification, nil
|
|
}
|
|
|
|
func (t *testNotifiable) Lang() string {
|
|
return t.Language
|
|
}
|
|
|
|
func TestNotify(t *testing.T) {
|
|
t.Run("normal", func(t *testing.T) {
|
|
|
|
s := db.NewSession()
|
|
_, err := s.Exec("delete from notifications")
|
|
require.NoError(t, err)
|
|
require.NoError(t, s.Commit())
|
|
s.Close()
|
|
|
|
tn := &testNotification{
|
|
Test: "somethingsomething",
|
|
OtherValue: 42,
|
|
}
|
|
tnf := &testNotifiable{
|
|
ShouldSendNotification: true,
|
|
Language: "en",
|
|
}
|
|
|
|
err = Notify(tnf, tn)
|
|
require.NoError(t, err)
|
|
vals := map[string]interface{}{
|
|
"notifiable_id": 42,
|
|
"notification": "'{\"other_value\":42,\"test\":\"somethingsomething\"}'",
|
|
}
|
|
|
|
if db.Type() == schemas.POSTGRES {
|
|
vals["notification::jsonb"] = vals["notification"].(string) + "::jsonb"
|
|
delete(vals, "notification")
|
|
}
|
|
|
|
if db.Type() == schemas.SQLITE {
|
|
vals["CAST(notification AS BLOB)"] = "CAST(" + vals["notification"].(string) + " AS BLOB)"
|
|
delete(vals, "notification")
|
|
}
|
|
|
|
db.AssertExists(t, "notifications", vals, true)
|
|
})
|
|
t.Run("disabled notifiable", func(t *testing.T) {
|
|
|
|
s := db.NewSession()
|
|
_, err := s.Exec("delete from notifications")
|
|
require.NoError(t, err)
|
|
require.NoError(t, s.Commit())
|
|
s.Close()
|
|
|
|
tn := &testNotification{
|
|
Test: "somethingsomething",
|
|
OtherValue: 42,
|
|
}
|
|
tnf := &testNotifiable{
|
|
ShouldSendNotification: false,
|
|
Language: "en",
|
|
}
|
|
|
|
err = Notify(tnf, tn)
|
|
require.NoError(t, err)
|
|
db.AssertMissing(t, "notifications", map[string]interface{}{
|
|
"notifiable_id": 42,
|
|
})
|
|
})
|
|
}
|