mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-05-04 19:06:28 +00:00
39b4568bc5
This changes the error handling to a centralized HTTP error handler in `pkg/routes/error_handler.go` that converts all error types to proper HTTP responses. This simplifies the overall error handling because http handler now only need to return the error instead of calling HandleHTTPError as previously. It also removes the duplication between handling errors with and without Sentry. 🐰 Hop along, dear errors, no more wrapping today! We've centralized handlers in a shiny new way, From scattered to unified, the code flows so clean, ValidationHTTPError marshals JSON supreme! Direct propagation hops forward with glee, A refactor so grand—what a sight to see! 🎉
93 lines
2.5 KiB
Go
93 lines
2.5 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package handler
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/log"
|
|
"code.vikunja.io/api/pkg/models"
|
|
"code.vikunja.io/api/pkg/modules/auth"
|
|
|
|
"github.com/labstack/echo/v4"
|
|
)
|
|
|
|
// UpdateWeb is the webhandler to update an object
|
|
func (c *WebHandler) UpdateWeb(ctx echo.Context) error {
|
|
|
|
// Get our model
|
|
currentStruct := c.EmptyStruct()
|
|
|
|
// Get the object & bind params to struct
|
|
if err := ctx.Bind(currentStruct); err != nil {
|
|
log.Debugf("Invalid model error. Internal error was: %s", err.Error())
|
|
var he *echo.HTTPError
|
|
if errors.As(err, &he) {
|
|
return models.ErrInvalidModel{Message: fmt.Sprintf("%v", he.Message), Err: err}
|
|
}
|
|
return models.ErrInvalidModel{Err: err}
|
|
}
|
|
|
|
// Validate the struct
|
|
if err := ctx.Validate(currentStruct); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Check if the user has the permission to do that
|
|
currentAuth, err := auth.GetAuthFromClaims(ctx)
|
|
if err != nil {
|
|
return echo.NewHTTPError(http.StatusInternalServerError, "Could not determine the current user.").SetInternal(err)
|
|
}
|
|
|
|
// Create the db session
|
|
s := db.NewSession()
|
|
defer func() {
|
|
err = s.Close()
|
|
if err != nil {
|
|
log.Errorf("Could not close session: %s", err)
|
|
}
|
|
}()
|
|
|
|
canUpdate, err := currentStruct.CanUpdate(s, currentAuth)
|
|
if err != nil {
|
|
_ = s.Rollback()
|
|
return err
|
|
}
|
|
if !canUpdate {
|
|
_ = s.Rollback()
|
|
log.Warningf("Tried to update while not having the permissions for it (User: %v)", currentAuth)
|
|
return echo.NewHTTPError(http.StatusForbidden)
|
|
}
|
|
|
|
// Do the update
|
|
err = currentStruct.Update(s, currentAuth)
|
|
if err != nil {
|
|
_ = s.Rollback()
|
|
return err
|
|
}
|
|
|
|
err = s.Commit()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return ctx.JSON(http.StatusOK, currentStruct)
|
|
}
|