Files
vikunja/pkg/files/files_test.go
kolaente 0e1f44e57e refactor: replace afero with FileStorage interface
Replace the github.com/spf13/afero dependency with a purpose-built
FileStorage interface (Open, Write, Stat, Remove, MkdirAll) with three
implementations: localStorage (with basePath), s3Storage (with key
prefix), and memStorage (for tests).

Each implementation owns its base path — callers pass only file IDs.
Delete s3fs.go, change File.File from afero.File to io.ReadCloser,
and fix duplication flows to buffer content for seeking.
2026-03-20 10:59:44 +01:00

174 lines
4.2 KiB
Go

// Vikunja is a to-do list application to facilitate your life.
// Copyright 2018-present Vikunja and contributors. All rights reserved.
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
package files
import (
"bytes"
"image"
"image/png"
"io"
"os"
"testing"
"code.vikunja.io/api/pkg/db"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
type testauth struct {
id int64
}
func (a *testauth) GetID() int64 {
return a.id
}
func TestCreate(t *testing.T) {
t.Run("Normal", func(t *testing.T) {
initFixtures(t)
ta := &testauth{id: 1}
createdFile, err := Create(bytes.NewReader([]byte("testfile")), "testfile", 100, ta)
require.NoError(t, err)
// Check the file was created correctly
file := &File{ID: createdFile.ID}
err = file.LoadFileMetaByID()
require.NoError(t, err)
assert.Equal(t, int64(1), file.CreatedByID)
assert.Equal(t, "testfile", file.Name)
assert.Equal(t, uint64(100), file.Size)
})
t.Run("Too Large", func(t *testing.T) {
initFixtures(t)
ta := &testauth{id: 1}
_, err := Create(bytes.NewReader([]byte("testfile")), "testfile", 99999999999, ta)
require.Error(t, err)
assert.True(t, IsErrFileIsTooLarge(err))
})
}
func TestCreateDetectsMimeType(t *testing.T) {
initFixtures(t)
ta := &testauth{id: 1}
// Minimal valid PNG (1x1 pixel)
pngData := createMinimalPNG(t)
f, err := Create(bytes.NewReader(pngData), "test.png", uint64(len(pngData)), ta)
require.NoError(t, err)
assert.Equal(t, "image/png", f.Mime)
}
func TestCreateDetectsMimeTypePlainText(t *testing.T) {
initFixtures(t)
ta := &testauth{id: 1}
textData := []byte("hello world this is plain text")
f, err := Create(bytes.NewReader(textData), "readme.txt", uint64(len(textData)), ta)
require.NoError(t, err)
assert.Equal(t, "text/plain; charset=utf-8", f.Mime)
}
func createMinimalPNG(t *testing.T) []byte {
t.Helper()
img := image.NewRGBA(image.Rect(0, 0, 1, 1))
buf := &bytes.Buffer{}
require.NoError(t, png.Encode(buf, img))
return buf.Bytes()
}
func TestFile_Delete(t *testing.T) {
t.Run("Normal", func(t *testing.T) {
s := db.NewSession()
defer s.Close()
initFixtures(t)
f := &File{ID: 1}
err := f.Delete(s)
require.NoError(t, err)
})
t.Run("Nonexisting", func(t *testing.T) {
s := db.NewSession()
defer s.Close()
initFixtures(t)
f := &File{ID: 9999}
err := f.Delete(s)
require.Error(t, err)
assert.True(t, IsErrFileDoesNotExist(err))
})
}
func TestFile_LoadFileByID(t *testing.T) {
t.Run("Normal", func(t *testing.T) {
initFixtures(t)
f := &File{ID: 1}
err := f.LoadFileByID()
require.NoError(t, err)
})
t.Run("Nonexisting", func(t *testing.T) {
initFixtures(t)
f := &File{ID: 9999}
err := f.LoadFileByID()
require.Error(t, err)
assert.True(t, os.IsNotExist(err))
})
}
func TestFileSave_UsesStorage(t *testing.T) {
originalStorage := storage
t.Cleanup(func() {
storage = originalStorage
})
mem := newMemStorage()
storage = mem
content := []byte("test-content")
file := &File{ID: 123, Size: uint64(len(content))}
err := file.Save(bytes.NewReader(content))
require.NoError(t, err)
rc, err := mem.Open(file.fileID())
require.NoError(t, err)
defer rc.Close()
written, err := io.ReadAll(rc)
require.NoError(t, err)
assert.Equal(t, content, written)
}
func TestFile_LoadFileMetaByID(t *testing.T) {
t.Run("Normal", func(t *testing.T) {
initFixtures(t)
f := &File{ID: 1}
err := f.LoadFileMetaByID()
require.NoError(t, err)
assert.Equal(t, "test", f.Name)
})
t.Run("Nonexisting", func(t *testing.T) {
initFixtures(t)
f := &File{ID: 9999}
err := f.LoadFileMetaByID()
require.Error(t, err)
assert.True(t, IsErrFileDoesNotExist(err))
})
}