clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-28 15:00:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify exec-server transport connect naming

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
starr-openai
2026-05-05 13:21:10 -07:00
parent 21297834ed
commit 045c740618
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
codex-rs/exec-server/src/client.rs
View File

@@ -153,8 +153,8 @@ pub(crate) struct Session {
struct Inner {
client: RpcClient,
// Keep the connection alive for any transport-specific owned state such as
// the stdio child process. RpcClient only takes the runtime channels/tasks.
// Keep the underlying transport connection alive. RpcClient only takes the
// runtime channels/tasks it needs to drive the JSON-RPC client.
_connection: JsonRpcConnection,
// The remote transport delivers one shared notification stream for every
// process on the connection. Keep a local process_id -> session registry so
@@ -208,9 +208,11 @@ impl LazyRemoteExecServerClient {
pub(crate) async fn get(&self) -> Result<ExecServerClient, ExecServerError> {
self.client
// TODO: Add reconnect/disconnect handling here instead of reusing
// the first successfully initialized connection forever.
.get_or_try_init(|| {
let transport = self.transport.clone();
async move { ExecServerClient::connect_for_environment(transport).await }
async move { ExecServerClient::connect_for_transport(transport).await }
})
.await
.cloned()

2
codex-rs/exec-server/src/client_transport.rs
View File

@@ -21,7 +21,7 @@ const ENVIRONMENT_CONNECT_TIMEOUT: Duration = Duration::from_secs(5);
const ENVIRONMENT_INITIALIZE_TIMEOUT: Duration = Duration::from_secs(5);
impl ExecServerClient {
pub(crate) async fn connect_for_environment(
pub(crate) async fn connect_for_transport(
transport: crate::client_api::ExecServerTransport,
) -> Result<Self, ExecServerError> {
match transport {