clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tolerate HOME session delete consume failures

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Iliyan Malchev
2026-03-21 21:08:11 -07:00
parent 2d906945ac
commit 13770329f9
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
android/app/src/main/java/com/openai/codex/agent/SessionDetailActivity.kt
View File

@@ -413,14 +413,20 @@ class SessionDetailActivity : Activity() {
private fun deleteSession() {
val topLevelSession = topLevelSession(latestSnapshot) ?: return
thread {
runCatching {
if (topLevelSession.anchor == AgentSessionInfo.ANCHOR_HOME) {
var frameworkDeleteFailure: Throwable? = null
if (topLevelSession.anchor == AgentSessionInfo.ANCHOR_HOME) {
runCatching {
if (topLevelSession.state == AgentSessionInfo.STATE_COMPLETED) {
sessionController.consumeCompletedHomeSession(topLevelSession.sessionId)
} else {
sessionController.consumeHomeSessionPresentation(topLevelSession.sessionId)
}
}.onFailure { err ->
frameworkDeleteFailure = err
Log.w(TAG, "Failed to consume HOME session ${topLevelSession.sessionId} during delete", err)
}
}
runCatching {
dismissedSessionStore.dismiss(topLevelSession.sessionId)
childSessions(latestSnapshot).forEach { childSession ->
dismissedSessionStore.dismiss(childSession.sessionId)
@@ -428,7 +434,13 @@ class SessionDetailActivity : Activity() {
}.onFailure { err ->
showToast("Failed to delete session: ${err.message}")
}.onSuccess {
showToast("Deleted session")
showToast(
if (frameworkDeleteFailure == null) {
"Deleted session"
} else {
"Deleted session from Agent UI; framework consume failed"
},
)
finish()
}
}