clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(tui): remove secret masking in user input

Browse Source
This commit is contained in:
viyatb-oai
2026-01-28 22:53:07 -08:00
parent 080266989b
commit 2592a2a15b
1 changed files with 1 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
codex-rs/tui/src/bottom_pane/request_user_input/mod.rs
View File

@@ -32,7 +32,6 @@ use crate::render::renderable::Renderable;
use codex_core::protocol::Op;
use codex_protocol::request_user_input::RequestUserInputAnswer;
use codex_protocol::request_user_input::RequestUserInputEvent;
use codex_protocol::request_user_input::RequestUserInputQuestion;
use codex_protocol::request_user_input::RequestUserInputResponse;
use codex_protocol::user_input::TextElement;
use unicode_width::UnicodeWidthStr;
@@ -376,10 +375,7 @@ impl RequestUserInputOverlay {
}
fn restore_current_draft(&mut self) {
let mask_input = self
.current_question()
.is_some_and(Self::is_secret_question);
self.composer.set_mask_input(mask_input);
self.composer.set_mask_input(false);
self.composer
.set_placeholder_text(self.notes_placeholder().to_string());
self.composer.set_footer_hint_override(Some(Vec::new()));
@@ -406,18 +402,6 @@ impl RequestUserInputOverlay {
}
}
fn is_secret_question(question: &RequestUserInputQuestion) -> bool {
let has_options = question
.options
.as_ref()
.is_some_and(|options| !options.is_empty());
if has_options {
return false;
}
let id = question.id.as_str();
id.starts_with("global/") || id.starts_with("env/")
}
fn sync_composer_placeholder(&mut self) {
self.composer
.set_placeholder_text(self.notes_placeholder().to_string());
@@ -2029,30 +2013,6 @@ mod tests {
assert_eq!(answer.answers, vec!["super-secret".to_string()]);
}
#[test]
fn secret_questions_mask_rendered_input() {
let (tx, _rx) = test_sender();
let mut overlay = RequestUserInputOverlay::new(
request_event(
"turn-1",
vec![question_without_options("global/TEST_SECRET", "Secret")],
),
tx,
true,
false,
false,
);
overlay
.composer
.set_text_content("super-secret".to_string(), Vec::new(), Vec::new());
overlay.composer.move_cursor_to_end();
let snapshot = render_snapshot(&overlay, Rect::new(0, 0, 80, 12));
assert!(!snapshot.contains("super-secret"));
assert!(snapshot.contains("************"));
}
#[test]
fn notes_are_captured_for_selected_option() {
let (tx, mut rx) = test_sender();