clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-28 15:00:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix auto-review model override integration test

Browse Source
This commit is contained in:
won
2026-05-21 15:50:47 -07:00
parent 2b4d27d0b6
commit 27b37fdfa1
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
codex-rs/core/tests/suite/auto_review.rs
View File

@@ -7,6 +7,7 @@ use codex_models_manager::manager::RefreshStrategy;
use codex_protocol::config_types::ApprovalsReviewer;
use codex_protocol::config_types::ReasoningSummary;
use codex_protocol::models::PermissionProfile;
use codex_protocol::openai_models::ApplyPatchToolType;
use codex_protocol::openai_models::ConfigShellToolType;
use codex_protocol::openai_models::ModelInfo;
use codex_protocol::openai_models::ModelVisibility;
@@ -97,6 +98,11 @@ async fn remote_model_override_uses_catalog_model_for_strict_auto_review() -> Re
),
ev_completed("resp-guardian"),
]),
sse(vec![
ev_response_created("resp-parent-3"),
ev_assistant_message("msg-parent", "done"),
ev_completed("resp-parent-3"),
]),
],
)
.await;
@@ -193,8 +199,13 @@ async fn remote_model_override_uses_catalog_model_for_strict_auto_review() -> Re
let guardian_request = responses
.requests()
.into_iter()
.find(|request| request.body_contains_text("auto-review-model-override.txt"))
.expect("expected Guardian request for strict apply_patch");
.find(|request| {
request.body_contains_text("auto-review-model-override.txt")
&& request
.instructions_text()
.starts_with("You are judging one planned coding-agent action.")
})
.expect("expected Guardian request for apply_patch");
assert_eq!(
guardian_request.body_json()["model"].as_str(),
Some(review_model)
@@ -231,7 +242,7 @@ fn remote_model_with_auto_review_override(slug: &str, review_model: &str) -> Mod
support_verbosity: false,
default_verbosity: None,
availability_nux: None,
apply_patch_tool_type: None,
apply_patch_tool_type: Some(ApplyPatchToolType::Freeform),
web_search_tool_type: Default::default(),
truncation_policy: TruncationPolicyConfig::bytes(/*limit*/ 10_000),
supports_parallel_tool_calls: false,