clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always emit exit

Browse Source
This commit is contained in:
jif-oai
2026-01-20 19:12:10 +00:00
parent b6cb7d9570
commit 65d5cdd99b
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
codex-rs/core/src/tasks/review.rs
View File

@@ -77,20 +77,39 @@ impl SessionTask for ReviewTask {
// Spawn the review agent.
let agent_control = session.agent_control();
let thread_id = agent_control
let thread_id = match agent_control
.spawn_agent(
sub_agent_config,
None,
Some(SessionSource::SubAgent(SubAgentSource::Review)),
)
.await
.ok()?;
{
Ok(thread_id) => thread_id,
Err(err) => {
tracing::error!("Error while spawning review agent: {err:?}");
if !cancellation_token.is_cancelled() {
exit_review_mode(session.clone_session(), None, ctx.clone(), None).await;
}
return None;
}
};
if let Ok(mut guard) = self.sub_agent_thread_id.lock() {
*guard = Some(thread_id);
}
let mut status_rx = agent_control.subscribe_status(thread_id).await.ok()?;
let mut status_rx = match agent_control.subscribe_status(thread_id).await {
Ok(status_rx) => status_rx,
Err(err) => {
tracing::error!("Error while subscribing to review agent status: {err:?}");
if !cancellation_token.is_cancelled() {
exit_review_mode(session.clone_session(), None, ctx.clone(), Some(thread_id))
.await;
}
return None;
}
};
session
.session