mirror of
https://github.com/openai/codex.git
synced 2026-05-15 00:32:51 +00:00
codex: address PR review feedback (#22200)
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
@@ -280,7 +280,11 @@ impl<'a> ToolRuntime<UnifiedExecRequest, UnifiedExecProcess> for UnifiedExecRunt
|
||||
if let UnifiedExecShellMode::ZshFork(zsh_fork_config) = &self.shell_mode {
|
||||
let command =
|
||||
build_sandbox_command(&command, &req.cwd, &env, req.additional_permissions.clone())
|
||||
.map_err(|_| ToolError::Codex(CodexErr::InvalidRequest("missing command line for PTY".into())))?;
|
||||
.map_err(|_| {
|
||||
ToolError::Codex(CodexErr::InvalidRequest(
|
||||
"missing command line for PTY".into(),
|
||||
))
|
||||
})?;
|
||||
let options = unified_exec_options(attempt.network_denial_cancellation_token.clone());
|
||||
let mut exec_env = attempt
|
||||
.env_for(command, options, managed_network)
|
||||
@@ -331,7 +335,11 @@ impl<'a> ToolRuntime<UnifiedExecRequest, UnifiedExecProcess> for UnifiedExecRunt
|
||||
}
|
||||
let command =
|
||||
build_sandbox_command(&command, &req.cwd, &env, req.additional_permissions.clone())
|
||||
.map_err(|_| ToolError::Codex(CodexErr::InvalidRequest("missing command line for PTY".into())))?;
|
||||
.map_err(|_| {
|
||||
ToolError::Codex(CodexErr::InvalidRequest(
|
||||
"missing command line for PTY".into(),
|
||||
))
|
||||
})?;
|
||||
let options = unified_exec_options(attempt.network_denial_cancellation_token.clone());
|
||||
let mut exec_env = attempt
|
||||
.env_for(command, options, managed_network)
|
||||
|
||||
Reference in New Issue
Block a user