clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-02-01 22:47:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: un-ship undo (#8424)

Browse Source
This commit is contained in:
jif-oai
2025-12-22 09:53:03 +01:00
committed by GitHub
parent 4e6d6cd798
commit 7a8407bbb6
7 changed files with 13 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codex-rs/core/src/features.rs
View File

@@ -291,7 +291,7 @@ pub const FEATURES: &[FeatureSpec] = &[
id: Feature::GhostCommit,
key: "undo",
stage: Stage::Stable,
default_enabled: true,
default_enabled: false,
},
FeatureSpec {
id: Feature::ParallelToolCalls,

6
codex-rs/tui/src/chatwidget.rs
View File

@@ -1717,9 +1717,9 @@ impl ChatWidget {
}
self.request_exit();
}
SlashCommand::Undo => {
self.app_event_tx.send(AppEvent::CodexOp(Op::Undo));
}
// SlashCommand::Undo => {
// self.app_event_tx.send(AppEvent::CodexOp(Op::Undo));
// }
SlashCommand::Diff => {
self.add_diff_in_progress();
let tx = self.app_event_tx.clone();

12
codex-rs/tui/src/chatwidget/tests.rs
View File

@@ -1454,18 +1454,6 @@ async fn slash_resume_opens_picker() {
assert_matches!(rx.try_recv(), Ok(AppEvent::OpenResumePicker));
}
#[tokio::test]
async fn slash_undo_sends_op() {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(None).await;
chat.dispatch_command(SlashCommand::Undo);
match rx.try_recv() {
Ok(AppEvent::CodexOp(Op::Undo)) => {}
other => panic!("expected AppEvent::CodexOp(Op::Undo), got {other:?}"),
}
}
#[tokio::test]
async fn slash_rollout_displays_current_path() {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(None).await;

6
codex-rs/tui/src/slash_command.rs
View File

@@ -21,7 +21,7 @@ pub enum SlashCommand {
Resume,
Init,
Compact,
Undo,
// Undo,
Diff,
Mention,
Status,
@@ -45,7 +45,7 @@ impl SlashCommand {
SlashCommand::Compact => "summarize conversation to prevent hitting the context limit",
SlashCommand::Review => "review my current changes and find issues",
SlashCommand::Resume => "resume a saved chat",
SlashCommand::Undo => "ask Codex to undo a turn",
// SlashCommand::Undo => "ask Codex to undo a turn",
SlashCommand::Quit | SlashCommand::Exit => "exit Codex",
SlashCommand::Diff => "show git diff (including untracked files)",
SlashCommand::Mention => "mention a file",
@@ -75,7 +75,7 @@ impl SlashCommand {
| SlashCommand::Resume
| SlashCommand::Init
| SlashCommand::Compact
| SlashCommand::Undo
// | SlashCommand::Undo
| SlashCommand::Model
| SlashCommand::Approvals
| SlashCommand::Experimental

6
codex-rs/tui2/src/chatwidget.rs
View File

@@ -1581,9 +1581,9 @@ impl ChatWidget {
}
self.request_exit();
}
SlashCommand::Undo => {
self.app_event_tx.send(AppEvent::CodexOp(Op::Undo));
}
// SlashCommand::Undo => {
// self.app_event_tx.send(AppEvent::CodexOp(Op::Undo));
// }
SlashCommand::Diff => {
self.add_diff_in_progress();
let tx = self.app_event_tx.clone();

12
codex-rs/tui2/src/chatwidget/tests.rs
View File

@@ -1290,18 +1290,6 @@ async fn slash_resume_opens_picker() {
assert_matches!(rx.try_recv(), Ok(AppEvent::OpenResumePicker));
}
#[tokio::test]
async fn slash_undo_sends_op() {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(None).await;
chat.dispatch_command(SlashCommand::Undo);
match rx.try_recv() {
Ok(AppEvent::CodexOp(Op::Undo)) => {}
other => panic!("expected AppEvent::CodexOp(Op::Undo), got {other:?}"),
}
}
#[tokio::test]
async fn slash_rollout_displays_current_path() {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(None).await;

6
codex-rs/tui2/src/slash_command.rs
View File

@@ -20,7 +20,7 @@ pub enum SlashCommand {
Resume,
Init,
Compact,
Undo,
// Undo,
Diff,
Mention,
Status,
@@ -43,7 +43,7 @@ impl SlashCommand {
SlashCommand::Compact => "summarize conversation to prevent hitting the context limit",
SlashCommand::Review => "review my current changes and find issues",
SlashCommand::Resume => "resume a saved chat",
SlashCommand::Undo => "ask Codex to undo a turn",
// SlashCommand::Undo => "ask Codex to undo a turn",
SlashCommand::Quit | SlashCommand::Exit => "exit Codex",
SlashCommand::Diff => "show git diff (including untracked files)",
SlashCommand::Mention => "mention a file",
@@ -71,7 +71,7 @@ impl SlashCommand {
| SlashCommand::Resume
| SlashCommand::Init
| SlashCommand::Compact
| SlashCommand::Undo
// | SlashCommand::Undo
| SlashCommand::Model
| SlashCommand::Approvals
| SlashCommand::Review