mirror of
https://github.com/openai/codex.git
synced 2026-05-18 10:12:59 +00:00
Keep extension bundle registration simple
This commit is contained in:
@@ -590,11 +590,7 @@ impl ToolRegistryBuilder {
|
||||
self.handlers.insert(name, handler);
|
||||
}
|
||||
|
||||
pub fn register_tool_bundle(
|
||||
&mut self,
|
||||
bundle: ExtensionToolBundle,
|
||||
transform_spec: impl FnOnce(ToolSpec) -> ToolSpec,
|
||||
) {
|
||||
pub fn register_tool_bundle(&mut self, bundle: ExtensionToolBundle) {
|
||||
let tool_name = ToolName::plain(bundle.tool_name());
|
||||
if self.handlers.contains_key(&tool_name) {
|
||||
warn!("Skipping extension tool `{tool_name}`: handler already registered");
|
||||
@@ -610,7 +606,7 @@ impl ToolRegistryBuilder {
|
||||
return;
|
||||
}
|
||||
};
|
||||
self.push_spec(transform_spec(spec.clone()));
|
||||
self.push_spec(spec.clone());
|
||||
|
||||
let handler: Arc<dyn AnyToolHandler> = Arc::new(BundledToolHandler::new(bundle, spec));
|
||||
self.handlers.insert(tool_name, handler);
|
||||
|
||||
@@ -190,13 +190,7 @@ pub fn build_tool_registry_builder(
|
||||
}
|
||||
|
||||
for bundle in params.extension_tool_bundles.iter().cloned() {
|
||||
builder.register_tool_bundle(bundle, |spec| {
|
||||
if config.code_mode_enabled {
|
||||
codex_tools::augment_tool_spec_for_code_mode(spec)
|
||||
} else {
|
||||
spec
|
||||
}
|
||||
});
|
||||
builder.register_tool_bundle(bundle);
|
||||
}
|
||||
|
||||
builder
|
||||
|
||||
Reference in New Issue
Block a user