mirror of
https://github.com/openai/codex.git
synced 2026-04-24 14:45:27 +00:00
app-server tests: disable shell_snapshot for review suite (#11657)
## Why `suite::v2::review::review_start_with_detached_delivery_returns_new_thread_id` was failing on Windows CI due to an unrelated process crash during shell snapshot initialization (`tokio-runtime-worker` stack overflow). This review test suite validates review API behavior and should not depend on shell snapshot behavior. Keeping shell snapshot enabled in this fixture made the test flaky for reasons outside the scenario under test. ## What Changed - Updated the review suite test config in `codex-rs/app-server/tests/suite/v2/review.rs` to set: - `shell_snapshot = false` This keeps the review tests focused on review behavior by disabling shell snapshot initialization in this fixture. ## Verification - `cargo test -p codex-app-server` - Confirmed the previously failing Windows CI job for this test now passes on this PR.
This commit is contained in:
@@ -438,6 +438,7 @@ model_provider = "mock_provider"
|
||||
|
||||
[features]
|
||||
remote_models = false
|
||||
shell_snapshot = false
|
||||
|
||||
[model_providers.mock_provider]
|
||||
name = "Mock provider"
|
||||
|
||||
Reference in New Issue
Block a user