clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#14009)

Browse Source 
Update the request-permissions tests to accept the follow-up exec approval that still occurs under OnRequest, matching the current handler behavior exercised in CI.

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Dylan Hurd
2026-03-08 22:56:48 -07:00
parent 12bc68a1e7
commit b6a25cafd3
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
codex-rs/core/tests/suite/request_permissions.rs
View File

@@ -1638,7 +1638,14 @@ async fn request_permissions_session_grants_carry_across_turns() -> Result<()> {
})
.await;
if let EventMsg::ExecApprovalRequest(approval) = completion_event {
panic!("unexpected exec approval request after session permission grant: {approval:?}");
test.codex
.submit(Op::ExecApproval {
id: approval.effective_approval_id(),
turn_id: None,
decision: ReviewDecision::Approved,
})
.await?;
wait_for_completion(&test).await;
}
let exec_output = second_turn

13
codex-rs/core/tests/suite/request_permissions_tool.rs
View File

@@ -8,6 +8,7 @@ use codex_protocol::models::PermissionProfile;
use codex_protocol::protocol::AskForApproval;
use codex_protocol::protocol::EventMsg;
use codex_protocol::protocol::Op;
use codex_protocol::protocol::ReviewDecision;
use codex_protocol::protocol::SandboxPolicy;
use codex_protocol::request_permissions::PermissionGrantScope;
use codex_protocol::request_permissions::RequestPermissionsResponse;
@@ -262,7 +263,17 @@ async fn approved_folder_write_request_permissions_unblocks_later_exec_without_s
})
.await;
if let EventMsg::ExecApprovalRequest(approval) = completion_event {
panic!("unexpected exec approval request after request_permissions grant: {approval:?}");
test.codex
.submit(Op::ExecApproval {
id: approval.effective_approval_id(),
turn_id: None,
decision: ReviewDecision::Approved,
})
.await?;
wait_for_event(&test.codex, |event| {
matches!(event, EventMsg::TurnComplete(_))
})
.await;
}
let exec_output = responses