Compare commits

...

1 Commits

Author SHA1 Message Date
pakrym-oai
dffd9ae24d Code review skills 2026-04-17 16:21:37 -07:00
4 changed files with 48 additions and 0 deletions

View File

@@ -0,0 +1,13 @@
---
name: code-breaking-changes
description: Breacking
---
Search for breaking changes in external integration surfaces:
- app-server APIs
- CLI parameters
- configuration loading
- resuming sessions from existing rollouts
Do not stop after finding one issue, analyze all possible ways breaking changes can happen.

View File

@@ -0,0 +1,10 @@
---
name: code-review-change-size
description: Change size guidance (800 lines)
---
Unless the change is mechanical the total number of changed lines should not exceed 800 lines.
For complex logic changes the size should be under 500 lines.
If the change is larger consider how the change can be done in stages. This must be well informed and reasearch ed suggestion.
Optimize for the ease of review, group mechanical changes separately from complex logic changes.

View File

@@ -0,0 +1,11 @@
---
name: code-review-testing
description: Test authoring guidance
---
For agent changes prefer integration tests over unit tests. Integration tests are under `core/suite` and use `test_codex` to set up a test instance of codex.
Features change change the agent logic MUST add an integration test:
- Provide a list of major logic changes and user-facing behaviors that need to be tested.
Check whether there are existing helpers to make tests more streamlined and readable.

View File

@@ -0,0 +1,14 @@
---
name: code-review
description: Run a final code review on a pull request
---
Use subagents to review code using all code-review-* skills in this repository. One subagent per skill. Pass full skill path to subagents. Use xhigh reasoning.
You can return an unlimited number of findings.
Use raw Markdown to report findings.
Number findings for the ease of reference.
If the GitHub user running the review is the owner of the pull request add a `code-reviewed` label.
Do not leave GitHub comments unless explicitly asked.