Compare commits

...

1 Commits

Author SHA1 Message Date
Ahmed Ibrahim
704d219925 TUI: mark running for task-spawning ops 2026-01-27 12:15:04 -08:00
2 changed files with 29 additions and 2 deletions

View File

@@ -5187,8 +5187,15 @@ impl ChatWidget {
pub(crate) fn submit_op(&mut self, op: Op) {
// Record outbound operation for session replay fidelity.
crate::session_log::log_outbound_op(&op);
if matches!(&op, Op::Review { .. }) && !self.bottom_pane.is_task_running() {
self.bottom_pane.set_task_running(true);
let spawns_task = matches!(
&op,
Op::Review { .. } | Op::Undo | Op::Compact | Op::RunUserShellCommand { .. }
);
if spawns_task && !self.bottom_pane.is_task_running() {
self.agent_turn_running = true;
self.update_task_running_state();
self.bottom_pane.set_interrupt_hint_visible(true);
self.request_redraw();
}
if let Err(e) = self.codex_op_tx.send(op) {
tracing::error!("failed to submit op: {e}");

View File

@@ -1694,6 +1694,26 @@ async fn streaming_final_answer_keeps_task_running_state() {
assert!(!chat.bottom_pane.quit_shortcut_hint_visible());
}
#[tokio::test]
async fn task_spawning_ops_mark_running_optimistically() {
let (mut chat, _rx, mut op_rx) = make_chatwidget_manual(None).await;
assert!(!chat.bottom_pane.is_task_running());
chat.submit_op(Op::Undo);
let saw_undo = loop {
match op_rx.try_recv() {
Ok(Op::Undo) => break true,
Ok(_) => continue,
Err(TryRecvError::Empty) => break false,
Err(TryRecvError::Disconnected) => panic!("expected op but channel closed"),
}
};
assert!(saw_undo, "expected Op::Undo to be forwarded");
assert!(chat.bottom_pane.is_task_running());
}
#[tokio::test]
async fn ctrl_c_shutdown_works_with_caps_lock() {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(None).await;