disable lint?

up 1047 - Fri Mar 13 2026 15:26:11
fix types
2026-03-14 18:53:47 +00:00 · 2026-03-14 11:50:49 -07:00 · 2026-03-14 11:50:49 -07:00 · 2026-03-14 11:50:49 -07:00 · 2026-03-14 11:50:49 -07:00 · 2026-03-14 11:50:49 -07:00
9 changed files with 38 additions and 125 deletions
--- a/codex-rs/app-server-protocol/schema/json/ClientRequest.json
+++ b/codex-rs/app-server-protocol/schema/json/ClientRequest.json
@@ -871,24 +871,6 @@
        }
      ]
    },
-    "FunctionCallOutputPayload": {
-      "description": "The payload we send back to OpenAI when reporting a tool call result.\n\n`body` serializes directly as the wire value for `function_call_output.output`. `success` remains internal metadata for downstream handling.",
-      "properties": {
-        "body": {
-          "$ref": "#/definitions/FunctionCallOutputBody"
-        },
-        "success": {
-          "type": [
-            "boolean",
-            "null"
-          ]
-        }
-      },
-      "required": [
-        "body"
-      ],
-      "type": "object"
-    },
    "FuzzyFileSearchParams": {
      "properties": {
        "cancellationToken": {
@@ -1575,10 +1557,6 @@
                "null"
              ]
            },
-            "id": {
-              "type": "string",
-              "writeOnly": true
-            },
            "summary": {
              "items": {
                "$ref": "#/definitions/ReasoningItemReasoningSummary"
@@ -1594,7 +1572,6 @@
            }
          },
          "required": [
-            "id",
            "summary",
            "type"
          ],
@@ -1728,7 +1705,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
@@ -1793,7 +1770,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
--- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json
+++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json
@@ -7773,24 +7773,6 @@
          }
        ]
      },
-      "FunctionCallOutputPayload": {
-        "description": "The payload we send back to OpenAI when reporting a tool call result.\n\n`body` serializes directly as the wire value for `function_call_output.output`. `success` remains internal metadata for downstream handling.",
-        "properties": {
-          "body": {
-            "$ref": "#/definitions/v2/FunctionCallOutputBody"
-          },
-          "success": {
-            "type": [
-              "boolean",
-              "null"
-            ]
-          }
-        },
-        "required": [
-          "body"
-        ],
-        "type": "object"
-      },
      "GetAccountParams": {
        "$schema": "http://json-schema.org/draft-07/schema#",
        "properties": {
@@ -10208,10 +10190,6 @@
                  "null"
                ]
              },
-              "id": {
-                "type": "string",
-                "writeOnly": true
-              },
              "summary": {
                "items": {
                  "$ref": "#/definitions/v2/ReasoningItemReasoningSummary"
@@ -10227,7 +10205,6 @@
              }
            },
            "required": [
-              "id",
              "summary",
              "type"
            ],
@@ -10361,7 +10338,7 @@
                "type": "string"
              },
              "output": {
-                "$ref": "#/definitions/v2/FunctionCallOutputPayload"
+                "$ref": "#/definitions/v2/FunctionCallOutputBody"
              },
              "type": {
                "enum": [
@@ -10426,7 +10403,7 @@
                "type": "string"
              },
              "output": {
-                "$ref": "#/definitions/v2/FunctionCallOutputPayload"
+                "$ref": "#/definitions/v2/FunctionCallOutputBody"
              },
              "type": {
                "enum": [
--- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json
+++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json
@@ -4374,24 +4374,6 @@
        }
      ]
    },
-    "FunctionCallOutputPayload": {
-      "description": "The payload we send back to OpenAI when reporting a tool call result.\n\n`body` serializes directly as the wire value for `function_call_output.output`. `success` remains internal metadata for downstream handling.",
-      "properties": {
-        "body": {
-          "$ref": "#/definitions/FunctionCallOutputBody"
-        },
-        "success": {
-          "type": [
-            "boolean",
-            "null"
-          ]
-        }
-      },
-      "required": [
-        "body"
-      ],
-      "type": "object"
-    },
    "FuzzyFileSearchParams": {
      "$schema": "http://json-schema.org/draft-07/schema#",
      "properties": {
@@ -6953,10 +6935,6 @@
                "null"
              ]
            },
-            "id": {
-              "type": "string",
-              "writeOnly": true
-            },
            "summary": {
              "items": {
                "$ref": "#/definitions/ReasoningItemReasoningSummary"
@@ -6972,7 +6950,6 @@
            }
          },
          "required": [
-            "id",
            "summary",
            "type"
          ],
@@ -7106,7 +7083,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
@@ -7171,7 +7148,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
--- a/codex-rs/app-server-protocol/schema/json/v2/RawResponseItemCompletedNotification.json
+++ b/codex-rs/app-server-protocol/schema/json/v2/RawResponseItemCompletedNotification.json
@@ -133,24 +133,6 @@
        }
      ]
    },
-    "FunctionCallOutputPayload": {
-      "description": "The payload we send back to OpenAI when reporting a tool call result.\n\n`body` serializes directly as the wire value for `function_call_output.output`. `success` remains internal metadata for downstream handling.",
-      "properties": {
-        "body": {
-          "$ref": "#/definitions/FunctionCallOutputBody"
-        },
-        "success": {
-          "type": [
-            "boolean",
-            "null"
-          ]
-        }
-      },
-      "required": [
-        "body"
-      ],
-      "type": "object"
-    },
    "GhostCommit": {
      "description": "Details of a ghost commit created from a repository state.",
      "properties": {
@@ -413,10 +395,6 @@
                "null"
              ]
            },
-            "id": {
-              "type": "string",
-              "writeOnly": true
-            },
            "summary": {
              "items": {
                "$ref": "#/definitions/ReasoningItemReasoningSummary"
@@ -432,7 +410,6 @@
            }
          },
          "required": [
-            "id",
            "summary",
            "type"
          ],
@@ -566,7 +543,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
@@ -631,7 +608,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
--- a/codex-rs/app-server-protocol/schema/json/v2/ThreadResumeParams.json
+++ b/codex-rs/app-server-protocol/schema/json/v2/ThreadResumeParams.json
@@ -191,24 +191,6 @@
        }
      ]
    },
-    "FunctionCallOutputPayload": {
-      "description": "The payload we send back to OpenAI when reporting a tool call result.\n\n`body` serializes directly as the wire value for `function_call_output.output`. `success` remains internal metadata for downstream handling.",
-      "properties": {
-        "body": {
-          "$ref": "#/definitions/FunctionCallOutputBody"
-        },
-        "success": {
-          "type": [
-            "boolean",
-            "null"
-          ]
-        }
-      },
-      "required": [
-        "body"
-      ],
-      "type": "object"
-    },
    "GhostCommit": {
      "description": "Details of a ghost commit created from a repository state.",
      "properties": {
@@ -479,10 +461,6 @@
                "null"
              ]
            },
-            "id": {
-              "type": "string",
-              "writeOnly": true
-            },
            "summary": {
              "items": {
                "$ref": "#/definitions/ReasoningItemReasoningSummary"
@@ -498,7 +476,6 @@
            }
          },
          "required": [
-            "id",
            "summary",
            "type"
          ],
@@ -632,7 +609,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
@@ -697,7 +674,7 @@
              "type": "string"
            },
            "output": {
-              "$ref": "#/definitions/FunctionCallOutputPayload"
+              "$ref": "#/definitions/FunctionCallOutputBody"
            },
            "type": {
              "enum": [
--- a/codex-rs/app-server-protocol/src/export.rs
+++ b/codex-rs/app-server-protocol/src/export.rs
@@ -17,6 +17,7 @@ use crate::protocol::common::EXPERIMENTAL_CLIENT_METHODS;
 use anyhow::Context;
 use anyhow::Result;
 use anyhow::anyhow;
+use codex_protocol::protocol::RolloutLine;
 use schemars::JsonSchema;
 use schemars::schema_for;
 use serde::Serialize;
@@ -185,6 +186,12 @@ pub fn generate_json(out_dir: &Path) -> Result<()> {
    generate_json_with_experimental(out_dir, false)
 }

+pub fn generate_internal_json_schema(out_dir: &Path) -> Result<()> {
+    ensure_dir(out_dir)?;
+    write_json_schema::<RolloutLine>(out_dir, "RolloutLine")?;
+    Ok(())
+}
+
 pub fn generate_json_with_experimental(out_dir: &Path, experimental_api: bool) -> Result<()> {
    ensure_dir(out_dir)?;
    let envelope_emitters: Vec<JsonSchemaEmitter> = vec![
--- a/codex-rs/app-server-protocol/src/lib.rs
+++ b/codex-rs/app-server-protocol/src/lib.rs
@@ -6,6 +6,7 @@ mod schema_fixtures;

 pub use experimental_api::*;
 pub use export::GenerateTsOptions;
+pub use export::generate_internal_json_schema;
 pub use export::generate_json;
 pub use export::generate_json_with_experimental;
 pub use export::generate_ts;
--- a/codex-rs/cli/src/main.rs
+++ b/codex-rs/cli/src/main.rs
@@ -342,12 +342,17 @@ struct AppServerCommand {
 }

 #[derive(Debug, clap::Subcommand)]
+#[allow(clippy::enum_variant_names)]
 enum AppServerSubcommand {
    /// [experimental] Generate TypeScript bindings for the app server protocol.
    GenerateTs(GenerateTsCommand),

    /// [experimental] Generate JSON Schema for the app server protocol.
    GenerateJsonSchema(GenerateJsonSchemaCommand),
+
+    /// [internal] Generate internal JSON Schema artifacts for Codex tooling.
+    #[clap(hide = true)]
+    GenerateInternalJsonSchema(GenerateInternalJsonSchemaCommand),
 }

 #[derive(Debug, Args)]
@@ -376,6 +381,13 @@ struct GenerateJsonSchemaCommand {
    experimental: bool,
 }

+#[derive(Debug, Args)]
+struct GenerateInternalJsonSchemaCommand {
+    /// Output directory where internal JSON Schema artifacts will be written
+    #[arg(short = 'o', long = "out", value_name = "DIR")]
+    out_dir: PathBuf,
+}
+
 #[derive(Debug, Parser)]
 struct StdioToUdsCommand {
    /// Path to the Unix domain socket to connect to.
@@ -631,6 +643,9 @@ async fn cli_main(arg0_paths: Arg0DispatchPaths) -> anyhow::Result<()> {
                    gen_cli.experimental,
                )?;
            }
+            Some(AppServerSubcommand::GenerateInternalJsonSchema(gen_cli)) => {
+                codex_app_server_protocol::generate_internal_json_schema(&gen_cli.out_dir)?;
+            }
        },
        #[cfg(target_os = "macos")]
        Some(Subcommand::App(app_cli)) => {
--- a/codex-rs/protocol/src/models.rs
+++ b/codex-rs/protocol/src/models.rs
@@ -231,6 +231,7 @@ pub enum ResponseInputItem {
    },
    FunctionCallOutput {
        call_id: String,
+        #[schemars(with = "FunctionCallOutputBody")]
        output: FunctionCallOutputPayload,
    },
    McpToolCallOutput {
@@ -239,6 +240,7 @@ pub enum ResponseInputItem {
    },
    CustomToolCallOutput {
        call_id: String,
+        #[schemars(with = "FunctionCallOutputBody")]
        output: FunctionCallOutputPayload,
    },
    ToolSearchOutput {
@@ -306,6 +308,7 @@ pub enum ResponseItem {
    Reasoning {
        #[serde(default, skip_serializing)]
        #[ts(skip)]
+        #[schemars(skip)]
        id: String,
        summary: Vec<ReasoningItemReasoningSummary>,
        #[serde(default, skip_serializing_if = "should_serialize_reasoning_content")]
@@ -356,6 +359,7 @@ pub enum ResponseItem {
    // We keep this behavior centralized in `FunctionCallOutputPayload`.
    FunctionCallOutput {
        call_id: String,
+        #[schemars(with = "FunctionCallOutputBody")]
        output: FunctionCallOutputPayload,
    },
    CustomToolCall {
@@ -375,6 +379,7 @@ pub enum ResponseItem {
    // text or structured content items.
    CustomToolCallOutput {
        call_id: String,
+        #[schemars(with = "FunctionCallOutputBody")]
        output: FunctionCallOutputPayload,
    },
    ToolSearchOutput {
Author	SHA1	Message	Date
Keyan Zhang	483b9f0a7b	disable lint?	2026-03-14 11:50:49 -07:00
Keyan Zhang	fb7c7132e2	up 1047 - Fri Mar 13 2026 15:26:11	2026-03-14 11:50:49 -07:00
Keyan Zhang	abd3d1269f	fix types	2026-03-14 11:50:49 -07:00
Keyan Zhang	8055fbdb99	up 1039 - Fri Mar 13 2026 00:05:59	2026-03-14 11:50:49 -07:00
Keyan Zhang	3fa9679ab3	up 1038 - Fri Mar 13 2026 00:04:58	2026-03-14 11:50:49 -07:00
Keyan Zhang	7569622ebc	up 1037 - Thu Mar 12 2026 23:59:50	2026-03-14 11:50:49 -07:00
Keyan Zhang	d5686fa5de	no js	2026-03-14 11:50:49 -07:00
Keyan Zhang	97596c0524	up 1019 - Wed Mar 11 2026 22:39:06	2026-03-14 11:50:49 -07:00
Keyan Zhang	626e87e686	up 1018 - Wed Mar 11 2026 22:32:50	2026-03-14 11:50:49 -07:00
Keyan Zhang	1c04d80e62	up 1017 - Wed Mar 11 2026 22:28:26	2026-03-14 11:50:49 -07:00
Keyan Zhang	42a4f1d152	simplify	2026-03-14 11:50:49 -07:00
Keyan Zhang	e168c6a782	.	2026-03-14 11:50:49 -07:00
Keyan Zhang	d56c40d83d	simplify	2026-03-14 11:50:48 -07:00
Keyan Zhang	043fa36f5a	update	2026-03-14 11:50:48 -07:00
Keyan Zhang	7bd038a72c	schema	2026-03-14 11:50:48 -07:00
Keyan Zhang	b6973eb6e8	script	2026-03-14 11:50:48 -07:00
Keyan Zhang	41abe01dd8	add TS codegen	2026-03-14 11:50:48 -07:00