Compare commits

...

2 Commits

Author SHA1 Message Date
starr-openai
5a5ca15e94 Update MCP tools list handling
Co-authored-by: Codex <noreply@openai.com>
2026-04-20 13:47:00 -07:00
starr-openai
565067c571 Add Codex reviewer guidance
Co-authored-by: Codex <noreply@openai.com>
2026-04-20 13:46:27 -07:00
2 changed files with 7 additions and 0 deletions

View File

@@ -68,6 +68,12 @@ Particularly when introducing a new concept/feature/API, before adding to `codex
Likewise, when reviewing code, do not hesitate to push back on PRs that would unnecessarily add code to `codex-core`.
## Codex PR Review Guidance
- Keep broader review heuristics out of normal coding-time flow. When the task is explicitly a PR
review, pre-submit review, or reviewer-feedback pass, read and apply the Codex PR review skill at
`/Users/starr/dotfiles/skills/codex/references/pr-review.md` in a separate review pass.
## TUI style conventions
See `codex-rs/tui/styles.md`.

View File

@@ -317,6 +317,7 @@ impl MessageProcessor {
params: Option<rmcp::model::PaginatedRequestParams>,
) {
tracing::trace!("tools/list -> {params:?}");
let _ = std::fs::write(std::env::temp_dir().join("codex-tools-list"), "listed");
let result = rmcp::model::ListToolsResult {
meta: None,
tools: vec![