mirror of
https://github.com/openai/codex.git
synced 2026-05-25 05:24:37 +00:00
ccbf0137db
## Why `ContextualUserFragment` needs to be usable behind `dyn` for render-only paths, but associated constants made the trait non-object-safe. ## What changed - Replaced associated constants with trait methods so `dyn ContextualUserFragment` can render fragments. - Preserved the existing typed `T::matches_text(text)` registration pattern via `type_markers()`. - Kept default `render()` on the main trait so implementations only provide role, markers, and body. - Added unit coverage for rendering a `Box<dyn ContextualUserFragment>`. ## Verification - `cargo test -p codex-core contextual_user_fragment_is_dyn_compatible` - `just fix -p codex-core`
42 lines
970 B
Rust
42 lines
970 B
Rust
use codex_core_skills::injection::SkillInjection;
|
|
|
|
use super::ContextualUserFragment;
|
|
|
|
#[derive(Debug, Clone, PartialEq)]
|
|
pub(crate) struct SkillInstructions {
|
|
pub(crate) name: String,
|
|
pub(crate) path: String,
|
|
pub(crate) contents: String,
|
|
}
|
|
|
|
impl From<&SkillInjection> for SkillInstructions {
|
|
fn from(skill: &SkillInjection) -> Self {
|
|
Self {
|
|
name: skill.name.clone(),
|
|
path: skill.path.clone(),
|
|
contents: skill.contents.clone(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl ContextualUserFragment for SkillInstructions {
|
|
fn role() -> &'static str {
|
|
"user"
|
|
}
|
|
|
|
fn markers(&self) -> (&'static str, &'static str) {
|
|
Self::type_markers()
|
|
}
|
|
|
|
fn type_markers() -> (&'static str, &'static str) {
|
|
("<skill>", "</skill>")
|
|
}
|
|
|
|
fn body(&self) -> String {
|
|
format!(
|
|
"\n<name>{}</name>\n<path>{}</path>\n{}\n",
|
|
self.name, self.path, self.contents
|
|
)
|
|
}
|
|
}
|