fix: addresses code review fixes

This commit is contained in:
Haoji Xu
2020-08-10 20:36:39 +08:00
committed by Tienson Qin
parent e7ca7a174f
commit 31fb7890de
2 changed files with 6 additions and 3 deletions

View File

@@ -361,12 +361,15 @@
[:p.opacity-70.font-medium "Empty"]])))
(rum/defc all-pages < rum/reactive
{:did-mount (fn [state]
(let [current-repo (state/sub :git/current-repo)]
(db/remove-orphaned-pages! current-repo))
state)}
[]
(let [current-repo (state/sub :git/current-repo)]
[:div.flex-1
[:h1.title "All Pages"]
(when current-repo
(db/remove-orphaned-pages! current-repo)
(let [pages (db/get-pages-with-modified-at current-repo)]
[:table.table-auto
[:thead

View File

@@ -1993,12 +1993,12 @@
(defn remove-orphaned-pages!
[repo]
(let [empty-pages (get-pages repo)
(let [all-pages (get-pages repo)
orphaned-pages (remove nil? (map (fn [page]
(let [name (string/lower-case page)]
(if (and (empty? (get-pages-that-mentioned-page repo name))
(not (journal-page? name))
(empty? (get-page-headings name))) name nil))) empty-pages))
(empty? (get-page-headings name))) name nil))) all-pages))
transaction (mapv (fn [name] [:db/retractEntity (:db/id (get-page (str name)))]) orphaned-pages)]
(transact! transaction)))