clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-28 14:39:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(icon): replace js/console.error with lambdaisland.glogi

Browse Source 
Logseq convention is to log via lambdaisland.glogi (already used across
handler/, worker/, etc.). Four console.error sites in icon.cljs ported
to log/error with structured event keywords and context maps:

- :icon/url-asset-fetch-failed       {:url :error}
- :icon/url-asset-ipc-failed         {:url :error}
- :icon/grid-subvec-failed           {:start :end :count :error}
- :icon/clipboard-paste-failed       {:error}

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
scheinriese
2026-05-19 13:53:24 +02:00
parent b3fcc314ba
commit 3b80bce2ea
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/frontend/components/icon.cljs
View File

@@ -30,6 +30,7 @@
[frontend.util :as util]
[goog.functions :refer [debounce]]
[goog.object :as gobj]
[lambdaisland.glogi :as log]
[logseq.common.config :as common-config]
[logseq.common.path :as path]
[logseq.db :as ldb]
@@ -1471,7 +1472,7 @@
(reject (ex-info "Failed to download"
{:kind :http-status :status (.-status response) :url url})))))
(.catch (fn [^js err]
(js/console.error "Download via fetch failed for" url err)
(log/error :icon/url-asset-fetch-failed {:url url :error err})
;; In a browser build, TypeError from a CORS-mode fetch almost always
;; means the target blocked cross-origin access. We can't distinguish
;; true network failures from CORS rejections here — the browser
@@ -1536,7 +1537,7 @@
:kind final-kind
:status status})))))
(p/catch (fn [^js err]
(js/console.error "Download via IPC failed for" url err)
(log/error :icon/url-asset-ipc-failed {:url url :error err})
(if (ex-data err)
(throw err)
(throw (ex-info "Network error"
@@ -2139,7 +2140,8 @@
end (* (inc idx) (if (and last? (not (zero? mods))) mods step))
icons (try (subvec items start end)
(catch js/Error e
(js/console.error e)
(log/error :icon/grid-subvec-failed
{:start start :end end :count (count items) :error e})
nil))]
(vec (map-indexed
(fn [c-idx item]
@@ -3708,7 +3710,7 @@
:error
(shui/toast! (t :icon.clipboard/read-error) :warning)))
(p/catch (fn [err]
(js/console.error "clipboard paste failed" err)
(log/error :icon/clipboard-paste-failed {:error err})
(shui/toast! (url-save-error-copy err) :error))))))
;; Keep the DOM paste listener pointed at the freshest closure.