clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-27 14:14:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: convert tag to page leaves class specific properties

Browse Source 
This could lead to subtle bugs with pages accidentally taking on
class-like behavior
This commit is contained in:
Gabriel Horner
2025-05-22 11:53:14 -04:00
parent 404c316d4c
commit 78a89f67e1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/frontend/handler/db_based/page.cljs
View File

@@ -65,6 +65,8 @@
(fn convert-fn []
(let [page-txs [[:db/retract (:db/id page-entity) :db/ident]
[:db/retract (:db/id page-entity) :block/tags :logseq.class/Tag]
[:db/retract (:db/id page-entity) :logseq.property.class/extends]
[:db/retract (:db/id page-entity) :logseq.property.class/properties]
[:db/add (:db/id page-entity) :block/tags :logseq.class/Page]]
obj-txs (mapcat (fn [obj]
(let [tags (map #(db/entity (state/get-current-repo) (:db/id %)) (:block/tags obj))]
@@ -75,7 +77,7 @@
txs (concat page-txs obj-txs)]
(db/transact! (state/get-current-repo) txs {:outliner-op :save-block})))]
(-> (shui/dialog-confirm!
"Converting a tag to page also removes tags from any nodes that have that tag. Are you ok with that?"
"Converting a tag to page also removes its tag properties and its tag from all nodes tagged with it. Are you ok with that?"
{:id :convert-tag-to-page
:data-reminder :ok})
(p/then convert-fn)))))))