clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-23 12:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: changing property type or cardinality

Browse Source 
doesn't update its timestamp. Changing a property's core behavior is
worthy of a timestamp update
This commit is contained in:
Gabriel Horner
2025-01-20 17:12:16 -05:00
parent bb1f20048c
commit 7b2d5ceebd
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
deps/outliner/src/logseq/outliner/property.cljs vendored
View File

@@ -93,8 +93,9 @@
old-ref-type? (db-property-type/user-ref-property-types old-type)
ref-type? (db-property-type/user-ref-property-types new-type)]
(cond-> [(cond->
{:db/ident ident
:db/cardinality cardinality}
(outliner-core/block-with-updated-at
{:db/ident ident
:db/cardinality cardinality})
ref-type?
(assoc :db/valueType :db.type/ref))]
(and new-type old-ref-type? (not ref-type?))

7
deps/outliner/test/logseq/outliner/property_test.cljs vendored
View File

@@ -16,8 +16,11 @@
(testing "Updates a property"
(let [conn (db-test/create-conn-with-blocks {:properties {:num {:logseq.property/type :number}}})
_ (outliner-property/upsert-property! conn :user.property/num {:type :default :cardinality :many} {})]
(is (db-property/many? (d/entity @conn :user.property/num)))))
old-updated-at (:block/updated-at (d/entity @conn :user.property/num))
_ (outliner-property/upsert-property! conn :user.property/num {:cardinality :many} {})]
(is (db-property/many? (d/entity @conn :user.property/num)))
(is (> (:block/updated-at (d/entity @conn :user.property/num))
old-updated-at))))
(testing "Multiple properties that generate the same initial :db/ident"
(let [conn (db-test/create-conn-with-blocks [])]